Closed Bug 1213745 Opened 4 years ago Closed 4 years ago

IonMonkey: MIPS64: Import Lowering-mips64

Categories

(Core :: JavaScript Engine: JIT, defect)

Other
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: hev, Assigned: hev)

References

Details

Attachments

(1 file)

Bug 1140954, Part 7: Lowering-mips64.
Thanks!
Attachment #8672507 - Flags: review?(nicolas.b.pierron)
Attachment #8672507 - Flags: review?(branislav.rankov)
Comment on attachment 8672507 [details] [diff] [review]
Part 7: Import Lowering-mips64.

Review of attachment 8672507 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/mips64/Lowering-mips64.cpp
@@ +105,5 @@
> +{
> +    MDefinition* opd = ins->input();
> +    MOZ_ASSERT(opd->type() == MIRType_Double);
> +
> +    define(new(alloc()) LTruncateDToInt32(useRegister(opd), tempDouble()), ins);

nit: Split this to 2 lines, one for the allocation and one for the define function call.

@@ +114,5 @@
> +{
> +    MDefinition* opd = ins->input();
> +    MOZ_ASSERT(opd->type() == MIRType_Float32);
> +
> +    define(new(alloc()) LTruncateFToInt32(useRegister(opd), tempFloat32()), ins);

nit: same here.

@@ +122,5 @@
> +LIRGeneratorMIPS64::visitRandom(MRandom* ins)
> +{
> +    LRandom *lir = new(alloc()) LRandom(temp(),
> +                                        temp(),
> +                                        temp());

nit: no need to wrap around the arguments.
Attachment #8672507 - Flags: review?(nicolas.b.pierron) → review+
https://hg.mozilla.org/mozilla-central/rev/e6334551d301
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.