1213749 - IonMonkey: MIPS64: Import SharedIC-mips64

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[hev [:hev]]

Bug 1140954, Part 10: SharedIC-mips64.

Comment 1

[hev [:hev]]

Attachment: Part 10: Import SharedIC-mips64.

Thanks!

Comment 2

[Nicolas B. Pierron [:nbp]]

Comment on attachment 8672510 [details] [diff] [review]
Part 10: Import SharedIC-mips64.

Review of attachment 8672510 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/mips64/SharedIC-mips64.cpp
@@ +163,5 @@
> +
> +    switch (op) {
> +      case JSOP_BITNOT:
> +        masm.not32(R0.valueReg());
> +        masm.tagValue(JSVAL_TYPE_INT32, R0.valueReg(), R0);

Does the not32 operation zeroed the upper part of the register on mips64?

@@ +171,5 @@
> +        // Guard against 0 and MIN_INT, both result in a double.
> +        masm.branchTest32(Assembler::Zero, ExtractTemp0, Imm32(INT32_MAX), &failure);
> +
> +        masm.neg32(ExtractTemp0);
> +        masm.tagValue(JSVAL_TYPE_INT32, ExtractTemp0, R0);

Same with neg32?

Comment 3

[hev [:hev]]

(In reply to Nicolas B. Pierron [:nbp] from comment #2)
> Comment on attachment 8672510 [details] [diff] [review]
> Part 10: Import SharedIC-mips64.
> 
> Review of attachment 8672510 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: js/src/jit/mips64/SharedIC-mips64.cpp
> @@ +163,5 @@
> > +
> > +    switch (op) {
> > +      case JSOP_BITNOT:
> > +        masm.not32(R0.valueReg());
> > +        masm.tagValue(JSVAL_TYPE_INT32, R0.valueReg(), R0);
> 
> Does the not32 operation zeroed the upper part of the register on mips64?
Yes, The 32-bit value is sign-extened in register on mips64.

> 
> @@ +171,5 @@
> > +        // Guard against 0 and MIN_INT, both result in a double.
> > +        masm.branchTest32(Assembler::Zero, ExtractTemp0, Imm32(INT32_MAX), &failure);
> > +
> > +        masm.neg32(ExtractTemp0);
> > +        masm.tagValue(JSVAL_TYPE_INT32, ExtractTemp0, R0);
> 
> Same with neg32?

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/16c2a146a493

Comment 5

[hev [:hev]]

https://hg.mozilla.org/mozilla-central/rev/16c2a146a493