Closed Bug 1213751 Opened 6 years ago Closed 6 years ago

IonMonkey: MIPS64: Import Simulator-mips64

Categories

(Core :: JavaScript Engine: JIT, defect)

Other
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox44 --- affected
firefox45 --- fixed

People

(Reporter: hev, Assigned: hev)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 1140954, Part 12: Simulator-mips64.
Thanks!
Attachment #8672512 - Flags: review?(nicolas.b.pierron)
Attachment #8672512 - Flags: review?(branislav.rankov)
Comment on attachment 8672512 [details] [diff] [review]
Part 12: Import Simulator-mips64.

Review of attachment 8672512 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry Jan, this is a big review :/
But I think you might have a better idea what details to look for as you already imported the ARM one.

::: js/src/jit/mips64/Simulator-mips64.cpp
@@ +59,5 @@
> +    if (cc == 0) {
> +        return 23;
> +    } else {
> +        return 24 + cc;
> +    }

style-nit: no braces for single statements, and no need for else clauses after a return.
Attachment #8672512 - Flags: review?(nicolas.b.pierron) → review?(jdemooij)
Blocks: 1218637
Blocks: 1218639
Blocks: 1213746
Updated, Fix coding-style and type cast.
Attachment #8672512 - Attachment is obsolete: true
Attachment #8672512 - Flags: review?(jdemooij)
Attachment #8672512 - Flags: review?(branislav.rankov)
Attachment #8681160 - Flags: review?(jdemooij)
Comment on attachment 8681160 [details] [diff] [review]
Part 12: Import Simulator-mips64.

Review of attachment 8681160 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay. Looks fine, I only skimmed this, as it's just the mips64 simulator and not something we ship to users.
Attachment #8681160 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/mozilla-central/rev/5140720f961b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.