12138 - crash migrating preferences from Communicator

Status: VERIFIED FIXED

(MailNews Core :: Profile Migration, defect, P2)

Description

[Dan M]

I'm getting a segmentation fault trying to migrate my Communicator preferences (Linux OS, but the error
will probably show up on other platforms).  To reproduce: replace mozilla prefs.js with my navigator preferences.js
and run -news.  What, your preferences.js is different?

The problem happens in nsMsgAccountManager:CopyIdentity.  In my case, the very last preference migrated,
srcIdentity->GetSmtpUserName, is returning a null value with a function return of NS_OK.  (Within
nsMsgIdentity::getCharPref, CopyCharPref returns an error, so the fallback getDefaultCharPref gets a shot.
It also fails, returning null, with a comment that says "null is ok to return here.")  Fine, but the following
call to destIdentity->SetSmtpUsername can't handle that null preference (it ends up in pref_SetValue, which
asserts that the string is not null.)

Actually, pref_SetValue seems to be able to handle a null string, but the PR_ASSERT kills the program.

Comment 1

[dbragg]

Seth, I reassigned this to you since you were working on the mail prefs.  I hope
you're also working on news prefs.  If it's not you, reassign as you see fit.

Comment 2

[(not reading, please use [e-mail] instead)]

yes, I own all mail / news pref migration.

accepting.

Comment 3

[(not reading, please use [e-mail] instead)]

marking m10.

Comment 4

[(not reading, please use [e-mail] instead)]

superb bug report.

I've checked in the fix.

QA:  to verify try to migrate a prefs.js file without any smtp prefs:
(remove the "mail.smtp_name" from your prefs.js before you migrate it.)

Comment 5

[Grace Bush]

19990913 build-able to use prefs.js file with smtp_name and no smtp_name