121382 - Sorting by order received doesn't clear sort direction indicator

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[[e-mail]]

Using Build ID: 2002012203
Steps to reproduce problem:
1. Sort by e.g. subject
2. Sort by order received (via menu)

Expected results: sort direction indicator on subject column is cleared

Actual results: sort direction indicator persists on subject column

Comment 1

[[e-mail]]

Attachment: Proposed patch; see also diff -uw below

Index: threadPane.js
===================================================================
RCS file: /cvsroot/mozilla/mailnews/base/resources/content/threadPane.js,v
retrieving revision 1.43
diff -u -w -r1.43 threadPane.js
--- threadPane.js	2002/01/16 03:01:08	1.43
+++ threadPane.js	2002/02/25 13:27:03
@@ -267,16 +267,16 @@
       else {
	 sortedColumn.setAttribute("sortDirection","descending");
       }
+    }
+  }

       // remove the sort indicator from all the columns
       // except the one we are sorted by
-      var currCol = sortedColumn.parentNode.firstChild;
+  var currCol = document.getElementById("threadCol");
       while (currCol) {
	 if (currCol != sortedColumn && currCol.localName == "outlinercol")
	   currCol.removeAttribute("sortDirection");
	 currCol = currCol.nextSibling;
-      }
-    }
   }
 }

Comment 2

[[e-mail]]

This was fixed by the patch to bug 44823.