Closed Bug 1213844 Opened 4 years ago Closed 4 years ago

Update Loop's user journey strings with final versions

Categories

(Hello (Loop) :: Client, defect, P1)

defect

Tracking

(firefox45 fixed)

RESOLVED FIXED
mozilla45
Iteration:
45.3 - Dec 14
Tracking Status
firefox45 --- fixed

People

(Reporter: standard8, Assigned: crafuse)

References

Details

(Whiteboard: [web sharing][strings])

User Story

Strings to be updated:
- Panel Button label: "Browse this page with a friend", "Stop sharing your tabs"
- Panel labels: "Recently browsed", "Currently browsing"
- Tooltip on Hello button when no one is in any of the rooms "Browse this page with a friend"
- Tooltip on Hello button when someone is in one of the rooms "Someone is waiting for you"
- Gear menu option "Turn notifications On/Off"
- Share panel strings: "<b>Invite someone to browse this page with you!</b> It takes two to use Firefox Hello, so send a friend a link to browse the Web with you!" "Your link:"
- Door hanger strings: "See you later! You can return to this shared session at any time through the Hello panel. "Would you like to give it a name that's easier to remember? Current name:" "OK"
- Infobar string: You are sharing your tabs. Any tab you click on can be seen by your friends" "Tab sharing is paused"
- Infobar buttons: "Pause" "Stop" "Restart"
- Conversation window strings: "Tab sharing is paused"

Attachments

(1 file, 9 obsolete files)

As part of the work for user journey, we're hard-coding strings whilst they are still in discussion. We should therefore replace these before shipping.

This depends on bug 1211351 which is currently deciding the strings.

Please add locations of any strings to the user story.
Depends on: 1213848
Depends on: 1213851
Rank: 20
Depends on: 1214214
Depends on: 1216791
In-product strings have now been confirmed through bug 1211351.
I now updated the user story field to confirm these.
Only pending strings are now the email and Facebook message strings that will be agreed on bug 1213906.
User Story: (updated)
User Story: (updated)
> - Panel Button label: "Browse this page with a friend", "Stop sharing your tabs"

The use of 'Page', 'Tab' and 'Session' really confuses me, when they all describe the same thing.

Solution: lets drop them.

1. 'Browse this with a friend'
2. 'Stop sharing'

> - Panel labels: "Recently browsed", "Currently browsing"

I'm not sure as a user whether I understand what I've browsed (from my Firefox browsing history) versus what I've shared (from my Firefox Hello history)? 

Suggestion: "Recently shared", "Currently sharing"

> - Tooltip on Hello button when someone is in one of the rooms "Someone is waiting for you"

Suggestion: Someone is waiting to browse with you

>- Door hanger strings: "See you later! You can return to this shared session at any time through the Hello panel. "Would you like to give it a name that's easier to remember? Current name:" "OK"

What's a session? And does a user know what the Hello panel is? How about 'button' or 'icon'?

Suggestion: "See you later! You can return to this at any time by clicking the Hello button/icon. "Would you like to add a name so it's easier to remember? Current name:"

> - Infobar string: You are sharing your tabs. Any tab you click on can be seen by your friends" "Tab sharing is paused"

The second use of 'tab' feels right here.

Suggestion: You are currently sharing. Any tab you click on can be seen by your friends. Sharing paused'

> - Conversation window strings: "Tab sharing is paused"   

Suggestion: 'Sharing paused'
Depends on: 1213906
I just updated the E-mail and facebook messages in the user story per what's agreed in bug 1213906
User Story: (updated)
Whiteboard: [web sharing] → [web sharing][strings]
I removed the e-mail and Facebook strings since they're looked after in bug 1213906 already.
User Story: (updated)
Iteration: --- → 45.2 - Nov 30
Assignee: nobody → chris.rafuse
Status: NEW → ASSIGNED
- Gear menu option "Turn notifications On/Off"
MISSING, ADD: "Turn notifications On/Off"
there are two strings, combine and ignore disabled or enabled state?

line ~95
FROM:
settings_menu_item_turnnotificationson=Turn Notifications On
settings_menu_item_turnnotificationsoff=Turn Notifications Off

TO NEW STRING:
settings_menu_item_turnnotifications_onoff=Turn Notifications On/Off
Flags: needinfo?(rtestard)
- Panel labels: "Recently browsed", "Currently browsing"
Keep caps or replace as above?

MODIFY: "Recently browsed", "Currently browsing"  as they are in CAPS
FROM:
## LOCALIZATION NOTE (rooms_list_recently_browsed): String is in all caps
## for emphasis reasons, it is a heading. Proceed as appropriate for locale.
rooms_list_recently_browsed=RECENTLY BROWSED
## LOCALIZATION NOTE (rooms_list_currently_browsing): String is in all caps
## for emphasis reasons, it is a heading. Proceed as appropriate for locale.
rooms_list_currently_browsing=CURRENTLY BROWSING

TO:
rooms_list_recently_browsed2=Recently browsed
rooms_list_currently_browsing2=Currently browsing
- Share panel strings: "<b>Invite someone to browse this page with you!</b> It takes two to use Firefox Hello, so send a friend a link to browse the Web with you!" "Your link:"  - IMPLEMENT CODE
MODIFY:
FROM:
invite_header_text2=Invite a friend to join you

TO:
invite_header_text_bold=Invite someone to browse this page with you!
invite_header_text3=It takes two to use Firefox Hello, so send a friend a link to browse the Web with you!
invite_your_link=Your link:
Do we have a Share panel strings (Comment 7) mockup?  I can place the text layout for this.
(In reply to Chris Rafuse from comment #5)
> - Gear menu option "Turn notifications On/Off"
> MISSING, ADD: "Turn notifications On/Off"
> there are two strings, combine and ignore disabled or enabled state?
> 
> line ~95
> FROM:
> settings_menu_item_turnnotificationson=Turn Notifications On
> settings_menu_item_turnnotificationsoff=Turn Notifications Off
> 
> TO NEW STRING:
> settings_menu_item_turnnotifications_onoff=Turn Notifications On/Off

Sorry Chris I missed the NI
The intent is to have either "Turn Notifications On" (if notifications are off) or "Turn Notifications Off" (if notifications are on) displayed in the gear menu.
Flags: needinfo?(rtestard)
(In reply to Chris Rafuse from comment #8)
> Do we have a Share panel strings (Comment 7) mockup?  I can place the text
> layout for this.

This is related to bug 1220627 which sill be planned in the next iteration (hopefully). Releasing the new user journey is not blocked by bug 1220627, these strings will only become useful when that bug gets done.
Hope this clarifies things
Attached patch Update share panel string layout (obsolete) — Splinter Review
Attachment #8693141 - Attachment is obsolete: true
Comment on attachment 8693142 [details] [diff] [review]
Update User Journey string properties

May remove: not needed.
loop-call-button3-active.tooltiptext = Active conversation

Added view code for roomViews.js/x.
Attachment #8693142 - Flags: review?(mdeboer)
Attachment #8693142 - Flags: review?(dmose)
Comment on attachment 8693142 [details] [diff] [review]
Update User Journey string properties

Review of attachment 8693142 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/locales/en-US/chrome/browser/customizableui/customizableWidgets.properties
@@ +100,5 @@
>  loop-call-button3-error.tooltiptext = Error!
>  loop-call-button3-donotdisturb.tooltiptext = Do not disturb
>  loop-call-button3-screensharing.tooltiptext = You are sharing your screen
>  loop-call-button3-active.tooltiptext2 = You are sharing your tabs
> +loop-call-button3-active.tooltiptext = Active conversation

What's this change doing here?

::: browser/locales/en-US/chrome/browser/loop/loop.properties
@@ +181,5 @@
>  help_label=Help
>  tour_label=Tour
>  
>  rooms_leave_button_label=Leave
> +## LOCALIZATION NOTE (rooms_list_recently_browsed2): String is in all caps

You can remove this localization note as it doesn't apply anymore.

@@ +186,3 @@
>  ## for emphasis reasons, it is a heading. Proceed as appropriate for locale.
> +rooms_list_recently_browsed2=Recently browsed
> +## LOCALIZATION NOTE (rooms_list_currently_browsing2): String is in all caps

Same here.

@@ +206,5 @@
>  # Infobar strings
>  
>  infobar_screenshare_browser_message=You are sharing your tabs. Any tab you click on can be seen by your friends
>  infobar_screenshare_paused_browser_message=Tab sharing is paused
> +infobar_button_gotit_label=Got it!

All these strings can not be added without using them somewhere in the application. This means that you'll need to replace the hardcoded strings with these in bootstrap.js and friends.
Attachment #8693142 - Flags: review?(mdeboer)
Attachment #8693142 - Flags: review?(dmose)
Attachment #8693142 - Flags: feedback+
Iteration: 45.2 - Nov 30 → 45.3 - Dec 14
Attached patch rooms_list_currently_browsing (obsolete) — Splinter Review
Attachment #8693710 - Attachment is obsolete: true
Comment on attachment 8693713 [details] [diff] [review]
Update User Journey string properties

Added needed strings.
Noted removals for strings not used after User Journey is updated.
Attachment #8693713 - Flags: review?(standard8)
Attachment #8693713 - Flags: review?(dmose)
Attachment #8693142 - Attachment is obsolete: true
Rank: 20 → 19
Priority: P2 → P1
Comment on attachment 8693713 [details] [diff] [review]
Update User Journey string properties

Given Mike's already provided feedback, I think its best to stick with him for the review.
Attachment #8693713 - Flags: review?(standard8)
Attachment #8693713 - Flags: review?(mdeboer)
Attachment #8693713 - Flags: review?(dmose)
Attachment #8693713 - Flags: review?
Attachment #8693713 - Flags: review?
Comment on attachment 8693713 [details] [diff] [review]
Update User Journey string properties

Review of attachment 8693713 [details] [diff] [review]:
-----------------------------------------------------------------

Apart from the comment below, do you have any comments, Francesco?

::: browser/locales/en-US/chrome/browser/loop/loop.properties
@@ +29,5 @@
>  ## LOCALIZATION_NOTE(first_time_experience_subheading): Message inviting the
>  ## user to create his or her first conversation.
>  first_time_experience_subheading=Join the conversation
>  
> +## REMOVE (invite_header_text2) after User Journey is updated.

I haven't seen this style of note before.

Please change the removal notice to:
`## LOCALIZATION NOTE (invite_header_text2) will be removed when bug XXX is implemented.`

Where 'bug XXX' should be replaced with an actual bug number of a bug you can file.
Attachment #8693713 - Flags: review?(mdeboer) → review?(francesco.lodolo)
Comment on attachment 8693713 [details] [diff] [review]
Update User Journey string properties

Review of attachment 8693713 [details] [diff] [review]:
-----------------------------------------------------------------

Clearing flag while some of the questions get answered.

I take we're not using most of the strings anywhere at the moment?

::: browser/locales/en-US/chrome/browser/loop/loop.properties
@@ +29,5 @@
>  ## LOCALIZATION_NOTE(first_time_experience_subheading): Message inviting the
>  ## user to create his or her first conversation.
>  first_time_experience_subheading=Join the conversation
>  
> +## REMOVE (invite_header_text2) after User Journey is updated.

I don't have a strong opinion on the format: '## REMOVE' is probably easier to search for in the file (I've seen # TODO used too in the past).

On the other hand, I completely agree on the proposed comment: localizers won't know what "User Journey is updated" means, put a reference to a bug and explain that the string will be removed at some point.

@@ +193,5 @@
>  ## for emphasis reasons, it is a heading. Proceed as appropriate for locale.
>  rooms_list_currently_browsing=CURRENTLY BROWSING
> +## LOCALIZATION NOTE (rooms_list_recently_browsed2): String is in all caps
> +## for emphasis reasons, it is a heading. Proceed as appropriate for locale.
> +rooms_list_recently_browsed2=Recently browsed

This is not all caps.

@@ +196,5 @@
> +## for emphasis reasons, it is a heading. Proceed as appropriate for locale.
> +rooms_list_recently_browsed2=Recently browsed
> +## LOCALIZATION NOTE (rooms_list_currently_browsing2): String is in all caps
> +## for emphasis reasons, it is a heading. Proceed as appropriate for locale.
> +rooms_list_currently_browsing2=Currently browsing

Same here, not all caps. Should it be?

@@ +221,2 @@
>  infobar_button_pause_label=Pause
> +infobar_button_restart_label=Restart

No accesskey for restart?

@@ +226,1 @@
>  infobar_button_pause_accesskey=P

Personal nit: put each accesskey near its string for this group of strings (I know most of them landed in a different patch).
Attachment #8693713 - Flags: review?(francesco.lodolo)
Attachment #8693713 - Attachment is obsolete: true
Comment on attachment 8694619 [details] [diff] [review]
Update Loop's user journey strings with final versions

Removed customizableWidgets.properties change.

updated notes.
Attachment #8694619 - Flags: review?(mdeboer)
Comment on attachment 8694619 [details] [diff] [review]
Update Loop's user journey strings with final versions

Review of attachment 8694619 [details] [diff] [review]:
-----------------------------------------------------------------

It's still unclear to me if the headers need to be uppercase for consistency with the rest.

::: browser/locales/en-US/chrome/browser/loop/loop.properties
@@ +221,4 @@
>  infobar_button_pause_label=Pause
> +infobar_button_pause_accesskey=P
> +infobar_button_restart_label=Restart
> +infobar_button_restart_accesskey=Q

Accesskey should be a character available in the string (e.g. 'e').
Comment on attachment 8694619 [details] [diff] [review]
Update Loop's user journey strings with final versions

Francesco provided very useful comments - I'll wait for the patch that addresses this.
Attachment #8694619 - Flags: review?(mdeboer)
Attachment #8694619 - Attachment is obsolete: true
Comment on attachment 8694770 [details] [diff] [review]
Update Loop's user journey strings with final versions

Changed access key from Q to E.
Attachment #8694770 - Flags: review?(mdeboer)
Attachment #8694770 - Attachment is obsolete: true
Attachment #8694770 - Flags: review?(mdeboer)
Comment on attachment 8694778 [details] [diff] [review]
Update Loop's user journey strings with final versions

Full changes.
Attachment #8694778 - Flags: review?(mdeboer)
Attachment #8694778 - Attachment is obsolete: true
Attachment #8694778 - Flags: review?(mdeboer)
Comment on attachment 8694782 [details] [diff] [review]
Update Loop's user journey strings with final versions

Removed notes and changed access key from E to e.
Attachment #8694782 - Flags: review?(mdeboer)
Comment on attachment 8694778 [details] [diff] [review]
Update Loop's user journey strings with final versions

Review of attachment 8694778 [details] [diff] [review]:
-----------------------------------------------------------------

A few things left to address!

::: browser/locales/en-US/chrome/browser/loop/loop.properties
@@ +30,5 @@
>  ## user to create his or her first conversation.
>  first_time_experience_subheading=Join the conversation
>  
> +
> +## LOCALIZATION NOTE (invite_header_text2) will be removed when bug 1209713 is implemented.

I wasn't really talking about a bug that's filed, but one that you have to file that will implement the other strings and remove this one.

@@ +189,1 @@
>  ## for emphasis reasons, it is a heading. Proceed as appropriate for locale.

Now you broke the comment.

@@ +192,1 @@
>  ## for emphasis reasons, it is a heading. Proceed as appropriate for locale.

Same here.

@@ +192,4 @@
>  ## for emphasis reasons, it is a heading. Proceed as appropriate for locale.
>  rooms_list_currently_browsing=CURRENTLY BROWSING
> +## LOCALIZATION NOTE (rooms_list_recently_browsed2):
> +## for emphasis reasons, it is a heading. Proceed as appropriate for locale.

Please remove this comment, it doesn't make sense.

@@ +194,5 @@
> +## LOCALIZATION NOTE (rooms_list_recently_browsed2):
> +## for emphasis reasons, it is a heading. Proceed as appropriate for locale.
> +rooms_list_recently_browsed2=Recently browsed
> +## LOCALIZATION NOTE (rooms_list_currently_browsing2):
> +## for emphasis reasons, it is a heading. Proceed as appropriate for locale.

ditto.
Attachment #8694778 - Attachment is obsolete: false
Attachment #8694782 - Attachment is obsolete: true
Attachment #8694782 - Flags: review?(mdeboer)
Attachment #8694778 - Attachment is obsolete: true
Comment on attachment 8695140 [details] [diff] [review]
Update Loop's user journey strings with final versions

Fixed and removed comments.

Created bug 1230058 for unused string removal.
Attachment #8695140 - Flags: review?(mdeboer)
Attachment #8695140 - Attachment is obsolete: true
Attachment #8695140 - Flags: review?(mdeboer)
Comment on attachment 8695155 [details] [diff] [review]
Update Loop's user journey strings with final versions

Added "String is in all caps" into heading comments
Attachment #8695155 - Flags: review?(mdeboer)
Attachment #8695155 - Flags: feedback+
Comment on attachment 8695155 [details] [diff] [review]
Update Loop's user journey strings with final versions

Review of attachment 8695155 [details] [diff] [review]:
-----------------------------------------------------------------

Now we're looking good :-) Thanks!
Attachment #8695155 - Flags: review?(mdeboer) → review+
https://hg.mozilla.org/integration/fx-team/rev/455af65081f54070206a8e38a512033311205282
Bug 1213844 - Update Loop's user journey strings with final versions [r=mikedeboer]
https://hg.mozilla.org/mozilla-central/rev/455af65081f5
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.