1213862 - Align XPCOM strings' idea of whitespace with web specs

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

The HTML and DOM specs define ASCII whitespace to be any of "\f\t\r\n ".  nsStringObsolete.cpp (the name seems misleading?) defines it to be "\b\t\r\n ".  Changing XPCOM to match the specs causes some unexpected passes and no unexpected fails:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7d58db02475a

I doubt anything internal will break if we slightly change how we handle backspace vs. form feed, and it makes things easier to be consistent in what we consider whitespace, so I suggest just changing XPCOM.

Comment 1

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Attachment: Patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d822ff1fde41

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8672624 [details] [diff] [review]
Patch

Review of attachment 8672624 [details] [diff] [review]:
-----------------------------------------------------------------

r=me assuming tests are green.

::: xpcom/string/nsStringObsolete.cpp
@@ -539,5 @@
>  }
>  
>  /* ***** END RICKG BLOCK ***** */
>  
> -static const char* kWhitespace="\b\t\r\n ";

I'm sure this made sense at some point, but it sure seems odd reading it now.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b69f59c4391f

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b69f59c4391f