Closed
Bug 1213866
Opened 9 years ago
Closed 9 years ago
Autophone - adb.py - add a logcat cleared message to the logcat whenever it is cleared so it is never completely empty
Categories
(Testing Graveyard :: Autophone, defect)
Testing Graveyard
Autophone
Tracking
(firefox44 affected)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox44 | --- | affected |
People
(Reporter: bc, Assigned: bc)
References
Details
Attachments
(1 file)
688 bytes,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
While Bug 1209653 helped production Autophone from falling behind as badly as it used to do especially for the nexus-s-3 device, it does not seem to have fixed the problem entirely. I have noticed that when disabling devices which should cancel pending jobs on Treeherder, my local nexus one devices appear to hang and take an inordinate amount of time to cancel jobs. One fix that works for me locally is to never allow the logcat to be completely empty. We can ensure this by adding a log message to the logcat immediately after clearing the buffer.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8672630 -
Flags: review?(jmaher)
Comment 2•9 years ago
|
||
Comment on attachment 8672630 [details] [diff] [review] bug-1213866-logcat-cleared-message-v1.patch Review of attachment 8672630 [details] [diff] [review]: ----------------------------------------------------------------- ::: adb.py @@ +1156,4 @@ > buffers = self._get_logcat_buffer_args(buffers) > cmds = ["logcat", "-c"] + buffers > self.command_output(cmds, timeout=timeout) > + self.shell_output("log logcat cleared", timeout=timeout) why the need for timeout here? I thought shell_output was issuing a command on the device.
Attachment #8672630 -
Flags: review?(jmaher) → review-
Assignee | ||
Comment 3•9 years ago
|
||
It is. The timeout prevents the command from hanging if the device does not respond.
Comment 4•9 years ago
|
||
Comment on attachment 8672630 [details] [diff] [review] bug-1213866-logcat-cleared-message-v1.patch Review of attachment 8672630 [details] [diff] [review]: ----------------------------------------------------------------- got it!
Attachment #8672630 -
Flags: review- → review+
Assignee | ||
Comment 5•9 years ago
|
||
https://github.com/mozilla/autophone/commit/107eaab32f3c6af47582fdee1fe9c781e3f6dcc2
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•2 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•