1213895 - Badge-Text should not be truncated with an ellipsis - hides more than necessary

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect)

Description

[Markus Jaritz [:designakt] (UX)]

With Bug 1207225 we limited the with of a badge to the width of its button. We also limit to 4 characters, but 4 wide characters might still require the badge text to be truncated. 
Currently we use an ellipsis, which is not ideal for this, as it hides 2 of the max. 4 characters.
Instead of "WWWW" one would only see "WW…" whereas with a hard cut one can see more, or most of the characters.

Comment 1

[Blake Winton (:bwinton) (:☕️)]

(Cc-ing Enn, cause he's looking into why the obvious change didn't work… 

Comment 2

[Kris Maglione [:kmag]]

Attachment: MozReview Request: Bug 1213895: Part 1 - Correctly support crop="none" in XUL labels. r?neil

Review commit: https://reviewboard.mozilla.org/r/33877/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33877/

Comment 3

[Kris Maglione [:kmag]]

Attachment: MozReview Request: Bug 1213895: Part 2 - Do not use ellipsis in cropped toolbarbutton badge text. r=bwinton

Review commit: https://reviewboard.mozilla.org/r/33879/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33879/

Comment 4

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 8716590 [details]
MozReview Request: Bug 1213895: Part 2 - Do not use ellipsis in cropped toolbarbutton badge text. r=bwinton

https://reviewboard.mozilla.org/r/33879/#review30533

Looks good to me.

(I think we might want a larger badge when the button is in the menu panel, but that can be a separate bug.  :)

Comment 5

[Neil Deakin]

Comment on attachment 8716589 [details]
MozReview Request: Bug 1213895: Part 1 - Correctly support crop="none" in XUL labels. r?neil

This part looks ok, but it changes the default crop value to 'none'. I think you want to make sure that 'end/right' is used as the default in nsTextBoxFrame::UpdateAttributes.

Comment 6

[Kris Maglione [:kmag]]

(In reply to Neil Deakin from comment #5)
> Comment on attachment 8716589 [details]
> MozReview Request: Bug 1213895: Part 1 - Correctly support crop="none" in
> XUL labels. r?neil
> 
> This part looks ok, but it changes the default crop value to 'none'. I think
> you want to make sure that 'end/right' is used as the default in
> nsTextBoxFrame::UpdateAttributes.

Hm. You're right. I thought it only defaulted to none for an attribute with an unknown value, but it defaults to it for a missing attribute too.

Comment 7

[Kris Maglione [:kmag]]

Comment on attachment 8716589 [details]
MozReview Request: Bug 1213895: Part 1 - Correctly support crop="none" in XUL labels. r?neil

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33877/diff/1-2/

Comment 8

[Kris Maglione [:kmag]]

Comment on attachment 8716590 [details]
MozReview Request: Bug 1213895: Part 2 - Do not use ellipsis in cropped toolbarbutton badge text. r=bwinton

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33879/diff/1-2/

Comment 9

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/fx-team/rev/d61da023339cd16d65aa60c93ce463617f10a5c8
Bug 1213895: Part 1 - Correctly support crop="none" in XUL labels. r=neil

https://hg.mozilla.org/integration/fx-team/rev/c5e7457caf709a38b23d41a9e2dd499edd97459e
Bug 1213895: Part 2 - Do not use ellipsis in cropped toolbarbutton badge text. r=bwinton

Comment 10

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/fx-team/rev/1b7bbed6b080ed5dedc8247a162b3269040d245f
Backout one changeset from bug 1213895 for M-oth bustage. r=bustage

Comment 11

[Kris Maglione [:kmag]]

Attachment: Part 1 - Correctly support crop="none" in XUL labels

Apparently we have code that relies on crop="none" being the default crop
type, and being almost, but not quite, the same as crop="right". In
particular, it does add an ellipsis when when the text is too long, but it
also sets the minimum width of the element to the width of the text.

Since we need the actual documented behavior of crop="none", and we can't
change the current behavior without breaking a lot of existing code, I added a
new crop="auto" type to handle the former behavior, and made it the default.

Comment 12

[Guilherme Lima]

Part 2 landed on M-C 8 hours ago: https://hg.mozilla.org/mozilla-central/rev/c5e7457caf70

Comment 13

[Neil Deakin]

Comment on attachment 8718223 [details] [diff] [review]
Part 1 - Correctly support crop="none" in XUL labels

OK, looks good.

Comment 14

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/fx-team/rev/62cc4b503870cf7be4ae0c530a3d7ab99c8585b9
Bug 1213895: Part 1 - Correctly support crop="none" in XUL labels. r=neil

Comment 15

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/62cc4b503870