1213922 - Autophone - call power_on after reboots and before s1s2 iterations

Status: RESOLVED FIXED

(Testing Graveyard :: Autophone, defect)

Description

[Bob Clary [:bc] (inactive)]

We currently call power on for devices during Autophone initialization but do not do so afterwards. I believe we should be calling it more often.

We should call it after every reboot.

I am beginning to think that perhaps some of our nytimes oranges might be due to the screen turning off after about 10 minutes. Many of the failures to get measurements in production are for test runs which take longer than 10 minutes. I just thought of this and added it to the s1s2 test for each iteration in this patch. I've run one test which was green on nytimes on my samsung which has a high incidence of nytimes orange, but I haven't tested enough builds to see whether this makes a real dent in the nytimes orange though.

Comment 1

[Bob Clary [:bc] (inactive)]

Attachment: bug-1213922-poweron-v1.patch

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8672693 [details] [diff] [review]
bug-1213922-poweron-v1.patch

Review of attachment 8672693 [details] [diff] [review]:
-----------------------------------------------------------------

this looks great, please answer the questions below.

::: tests/s1s2test.py
@@ +120,5 @@
>                  for iteration in range(1, self._iterations+1):
> +                    # Calling svc power stayon true will turn on the
> +                    # display for at least some devices if it has
> +                    # turned off.
> +                    self.dm.power_on()

do we need to do this for each iteration? should we consider this in other test specific runners?

Comment 3

[Bob Clary [:bc] (inactive)]

We could probably get away with not doing it for each iteration, but if we didn't then we'd have to figure out a periodic check that would make sure each iteration fit within the display timeout. I think it is just easier to put it at the beginning of the iteration for now. I didn't hit on this idea until late this morning, so apart from limited testing on a single build I don't have much history on it.

I think we definitely should consider it. Especially if this moves the orange needle on nytimes in production. I'm not entirely sure yet though. I'd like some history with this in place before do more.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

ok, that makes sense, should we leave this open or file a bug to track it?

Comment 5

[Bob Clary [:bc] (inactive)]

https://github.com/mozilla/autophone/commit/1469b9a3ee406da3cd4180143c56ef8a429a14a0

I'll NI myself to follow up on if this helps the nytimes orange or not.

Comment 6

[Bob Clary [:bc] (inactive)]

This *did not* help with the nytimes orange.