Make iOS Xcode build create a framework and example app

NEW
Unassigned

Status

()

Core
General
2 years ago
2 years ago

People

(Reporter: snorp, Unassigned)

Tracking

41 Branch
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Comment hidden (empty)
Created attachment 8672733 [details] [diff] [review]
Rework iOS Xcode project

This patch does a lot. The main points:

* s/GeckoEmbed/GeckoKit/ because of...reasons?
* The GeckoKit target builds a framework, with the main executable (dylib) being XUL. This means we won't use mozglue to load XUL. Performance on the device seems more than fine for this, and it dramatically simplifies things.
* Control the objdir and mozconfig via build-gecko.sh. This lets you change your scheme in Xcode and just hit the 'Run' button.
* Add a GeckoUIViewExample application which shows how you can use GeckoUIView. It contains a simple location bar with back/forward buttons.
Attachment #8672733 - Flags: review?(ted)
Duplicate of this bug: 1213964
Created attachment 8673721 [details] [diff] [review]
Rework iOS Xcode project (GeckoKit) and widget layer

I rolled the widget changes from bug 1213964 into this single giant patch for maximum unreadability.
Attachment #8673721 - Flags: review?(ted)
Comment on attachment 8672733 [details] [diff] [review]
Rework iOS Xcode project

Review of attachment 8672733 [details] [diff] [review]:
-----------------------------------------------------------------

I dunno why I let this sit so long, I don't actually care about the contents of this patch I just want you to land it. :)
Attachment #8672733 - Flags: review?(ted) → review+
Comment on attachment 8673721 [details] [diff] [review]
Rework iOS Xcode project (GeckoKit) and widget layer

Review of attachment 8673721 [details] [diff] [review]:
-----------------------------------------------------------------

I don't really want to review any of this. If it builds and runs on device that's fine with me, land it.
Attachment #8673721 - Flags: review?(ted) → review+
You need to log in before you can comment on or make changes to this bug.