1213972 - [RTL] replace scaleX(-1) with mirrored images

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Shared, defect)

Description

[Augustin Trancart [:autra]]

To mirror some icons and elements for RTL views, we previously used scaleX(-1). Let's replace these with:
- gaia-icons when possible
- mirrored version of these images.

We should gain in performance, especially when displaying lists.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] Phoxygen:bug1213972-rtl_remove_scaleX > mozilla-b2g:master

Comment 2

[Augustin Trancart [:autra]]

Comment on attachment 8680670 [details] [review]
[gaia] Phoxygen:bug1213972-rtl_remove_scaleX > mozilla-b2g:master

Hey Kevin,

I removed nearly every scaleX(-1) left after our RTL refacto. I've left 3:
- 2 for progress building block and for progress web component. 
- 1 for tv_apps/smart-system, out-of-scope for our current refacto effort.

Usually, removing these scaleX brings performance improvement. That was not the case for the 2 scaleX in progress bb and wc. The resulting code was more complex and did not bring any semantic improvement either. For this rtl refacto, one of our moto was "equivalent code for LTR and RTL", but I don't think it is worthy here.

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 8680670 [details] [review]
[gaia] Phoxygen:bug1213972-rtl_remove_scaleX > mozilla-b2g:master

I'm not sure I understand the benefit, but I'm fine rubber stamping this if you say it's better. 

Note: tests didn't run, but I do think that this should be fine to land since it's just purely CSS changes. Thanks for the patch!

Comment 4

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/c6c62adc6290d49d7e08c3d77b2b85b7e58a3659