Closed Bug 1214019 Opened 9 years ago Closed 9 years ago

Playing ringtones from Messenger app with no music in library will take user to non functioning music app

Categories

(Firefox OS Graveyard :: Gaia::Music, defect, P1)

ARM
Gonk (Firefox OS)
defect

Tracking

(blocking-b2g:2.5+, b2g-master verified)

VERIFIED FIXED
blocking-b2g 2.5+
Tracking Status
b2g-master --- verified

People

(Reporter: jthomas, Assigned: justindarc)

References

()

Details

(Whiteboard: [2.5-Daily-Testing][Spark] [investigation eta 10/18])

Attachments

(4 files)

Description:
If the user attempts to play a sent (or received) ringtone attachment from the messenger app they will be taken to the music app that does not play the ringtone. From the Music app the pause button is available to press (instead of play) but there is no timer displayed indicating the ringtone is being played.

Repro Steps:

Prereq: At least one song already within library.

1) Update a Aries to 20151012110414
2) Select Settings > Sound > Manage Tones
3) Select the "..." of any song.
4) Select Share ringtone > Messages
5) Send attachment to a contact.
6) Press Play on attachment from Messenger.

Actual:
User is taken to non functioning music app.

Expected:
It is expected that the messenger app will transition to the music app will play the ringtone successfully. 

Environmental Variables:
Device: Aries 2.5 Kk
BuildID: 20151012110414
Gaia: 87f5c9d55ab6a77dcfa48a3f3a8b4f5016f3c657
Gecko: 0b69d304f861d0038fb78f1d52b0f5d13ef7c6fe
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 44.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Repro frequency: 
See attached: Logcat & Video

Video: https://youtu.be/YTXOF49iZMM
This issue DOES occur on the Flame 2.5
Result: User is taken to a non functioning music app regarding the audio file they are attempting to play. I used 512mb instead of 319mb since the device would crash out each time I attempted to attach a ringtone to the message.

Environmental Variables:
Device: Flame 2.5 Kk Fullflash (512mb)
BuildID: 20151012030617
Gaia: 87f5c9d55ab6a77dcfa48a3f3a8b4f5016f3c657
Gecko: 0b69d304f861d0038fb78f1d52b0f5d13ef7c6fe
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 44.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

-----------------------------------------------------------------
This issue does NOT occur on the Flame 2.2.
Result: User is able to play an attached ringtone from message app successfully. 2.2 was also able to successfully attach a ringtone at 319mb without crashing.

Environmental Variables:
Device: Flame 2.2 Kk Fullflash (319mb)
BuildID: 20151006032504
Gaia: 5dd95cfb9f1d6501ce0e34414596ef3dd9c2f583
Gecko: fc588eb28eab
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
Keywords: regression
Whiteboard: [2.5-Daily-Testing][Spark]
blocking-b2g: --- → 2.5?
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
Flags: needinfo?(jmercado)
Flags: needinfo?(jmercado)
QA Contact: pcheng
On Flame engineering builds I was able to select whether to play the music in Music or Music OGA. The issue reproduces with Music, but NOT with Music OGA. This is a Music NGA bug.
QA Whiteboard: [QAnalyst-Triage?]
Component: Gaia::SMS → Gaia::Music
Flags: needinfo?(jmercado)
No-Jun, who should look at this issue?  It's NGA only.
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(jmercado) → needinfo?(npark)
I will take a look.
Assignee: nobody → jdarcangelo
Since it's already nomed and Justin is taking a look, clearing ni?
Flags: needinfo?(npark)
blocking-b2g: 2.5? → 2.5+
Priority: -- → P1
Similar to Bug 1214303
Whiteboard: [2.5-Daily-Testing][Spark] → [2.5-Daily-Testing][Spark] [investigation eta 10/18]
I am not able to reproduce this. Can this please be re-checked using today's build?
Flags: needinfo?(jthomas)
This issue IS still occurring on Aries Master and Flame 2.5. Are you certain there is audio already within the library? This will not occur if otherwise.
Result: User is taken to the Music app with the play button already active while no audio sound or timer active.

Environmental Variables:
Device: Aries 2.5 Kk
BuildID: 20151015110122
Gaia: 40ae7c292a36156458c66712b4bd61ecbe69272a
Gecko: e193b4da0a8c1025aa76a403c64663ff1cd41709
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 44.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Environmental Variables:
Device: Flame 2.5 Kk Fullflash (319mb)
BuildID: 20151015030226
Gaia: 40ae7c292a36156458c66712b4bd61ecbe69272a
Gecko: e193b4da0a8c1025aa76a403c64663ff1cd41709
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 44.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage?]
Flags: needinfo?(jthomas) → needinfo?(jmercado)
(In reply to John Thomas [:Johnt] from comment #8)
> This issue IS still occurring on Aries Master and Flame 2.5. Are you certain
> there is audio already within the library? This will not occur if otherwise.
> Result: User is taken to the Music app with the play button already active
> while no audio sound or timer active.
> 
> Environmental Variables:
> Device: Aries 2.5 Kk
> BuildID: 20151015110122
> Gaia: 40ae7c292a36156458c66712b4bd61ecbe69272a
> Gecko: e193b4da0a8c1025aa76a403c64663ff1cd41709
> Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
> Version: 44.0a1 (2.5) 
> Firmware Version: D5803_23.1.A.1.28_NCB.ftf
> User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0
> 
> Environmental Variables:
> Device: Flame 2.5 Kk Fullflash (319mb)
> BuildID: 20151015030226
> Gaia: 40ae7c292a36156458c66712b4bd61ecbe69272a
> Gecko: e193b4da0a8c1025aa76a403c64663ff1cd41709
> Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
> Version: 44.0a1 (2.5) 
> Firmware Version: v18D
> User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Yes, I have about 100 songs in my library and I am able to open an attached song from an SMS message using the Music app without any problems.

Out of curiosity, are your songs on internal storage or a removable SD card?
Using the same builds I referenced in Comment 8 I have successfully repro'd this issue with the following scenarios on both Aries and Flame 2.5.

1. One song in Internal - 0 songs on external.
2. Zero songs in Internal. - 1 song on external.
3. One song (the same) in both internal & external.

If you need any more logs or anything else please let me know.
(In reply to John Thomas [:Johnt] from comment #10)
> Using the same builds I referenced in Comment 8 I have successfully repro'd
> this issue with the following scenarios on both Aries and Flame 2.5.
> 
> 1. One song in Internal - 0 songs on external.
> 2. Zero songs in Internal. - 1 song on external.
> 3. One song (the same) in both internal & external.
> 
> If you need any more logs or anything else please let me know.

Thanks for checking!

Can you attach the ringtone you're using to send as an SMS? Perhaps its an issue with the ringtone itself. I'm running out of ideas :-/
Flags: needinfo?(jthomas)
Just to show I'm not making this up, here's a video of this workflow working for me on today's build on Flame :-)
Hub just told me on IRC he's able to reproduce this with an *empty* music library. So, I think what's happening is when you attempt to use the "open" activity when the music library has changed between launches. In that case, the "open" activity is probably failing to show the music scan progress and that is maybe causing this breakage. I'm going to investigate this further.
Interesting. I've attempted several ringtones just to make sure it is not a single tone causing the issue. At first I thought you were unable to repro this since it looks like the message did not actually send completely based upon your video. So I sent a ringtone out and activated airplane mode just to fail it to make sure that was not preventing the repro. I am stumped as well. Please let me know if there this anything else I can help out with.
Flags: needinfo?(jthomas)
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(jmercado)
(In reply to Justin D'Arcangelo [:justindarc] from comment #13)
> Hub just told me on IRC he's able to reproduce this with an *empty* music
> library. So, I think what's happening is when you attempt to use the "open"
> activity when the music library has changed between launches. In that case,
> the "open" activity is probably failing to show the music scan progress and
> that is maybe causing this breakage. I'm going to investigate this further.

Actually I was confusing with bug 1214303 :-/
Updating summary to reflect what's actually going on.
Summary: Playing attached ringtones from Messenger app with music already in library will take user to non functioning music app → Playing ringtones from Messenger app with no music in library will take user to non functioning music app
Attachment #8676422 - Flags: review?(squibblyflabbetydoo)
Comment on attachment 8676422 [details] [review]
[gaia] justindarc:bug1214019 > mozilla-b2g:master

I'm not sure this patch goes in the right way, since it seems to be assuming we want to access the music database from the open activity. I don't think we actually want that, though.
Attachment #8676422 - Flags: review?(squibblyflabbetydoo) → review-
Attachment #8676422 - Flags: review- → review+
Don't forget to file a followup about removing the DB code from the open activity.
See Also: → 1216811
See follow-up bug for removing DB code from the "open" activity (non-blocker).

Landed on master:

https://github.com/mozilla-b2g/gaia/commit/5f15617ec5d8f83f023195bcd31519da302cdbfc
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aires KK 2.5 by the STR in comment 0.

Actual results: The messenger app can transit to the music app and play the ringtone successfully.
See attachment: verified_Aries KK_v2.5.3gp.
Reproduce rate: 0/10.


Device: Flame KK 2.5 (Pass)
Build ID               20151022150207
Gaia Revision          29ce8ec8606e59f582375234440812b046346513
Gaia Date              2015-10-22 05:31:38
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/76bd0c01d72e64ca4f261ffdb2652a91f961e930
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151022.185000
Firmware Date          Thu Oct 22 18:50:13 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5 (Pass)
Build ID               20151023005002
Gaia Revision          29ce8ec8606e59f582375234440812b046346513
Gaia Date              2015-10-22 05:31:38
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/1f03a14106e59280761ac53904340f389674337f
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151023.001128
Firmware Date          Fri Oct 23 00:11:35 UTC 2015
Bootloader             s1
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage+][MGSEI-Triage+]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: