Closed Bug 1214055 Opened 4 years ago Closed 4 years ago

nsPNGDecoder is using the wrong surface format for detecting transparency during the metadata decode

Categories

(Core :: ImageLib, defect)

defect
Not set

Tracking

()

RESOLVED INVALID

People

(Reporter: seth, Assigned: seth)

References

Details

Attachments

(1 file)

In nsPNGDecoder::CreateFrame(), we force the first frame of a PNG to be transparent due to bug 1120141. We don't apply the same transformation when checking for transparency during the metadata decode, though, which causes the assertions I'm adding in bug 1210745 to fire. Until we fix bug 1120141, we need to always treat the first frame of a PNG as transparent, even during the metadata decode.
Here's the patch.
Attachment #8672892 - Flags: review?(tnikkel)
Attachment #8672892 - Flags: review?(tnikkel) → review+
(In reply to Seth Fowler [:seth] [:s2h] from comment #0)
> In nsPNGDecoder::CreateFrame(), we force the first frame of a PNG to be
> transparent due to bug 1120141.

We fixed this in bug 1120141...

> We don't apply the same transformation when
> checking for transparency during the metadata decode, though, which causes
> the assertions I'm adding in bug 1210745 to fire. Until we fix bug 1120141,
> we need to always treat the first frame of a PNG as transparent, even during
> the metadata decode.

...so we don't need to this anymore.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.