Closed
Bug 1214076
Opened 9 years ago
Closed 9 years ago
TokenServerClient errors can't be JSON.stringify'd
Categories
(Firefox :: Firefox Accounts, defect)
Firefox
Firefox Accounts
Tracking
()
RESOLVED
FIXED
Firefox 44
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | fixed |
People
(Reporter: markh, Assigned: markh)
Details
Attachments
(1 file)
|
2.34 KB,
patch
|
rnewman
:
review+
|
Details | Diff | Splinter Review |
...which results in, eg,
> Exception trying to format object for log message: TypeError: cyclic object value (resource://gre/modules/Log.jsm:670:14) JS Stack trace: ParameterFormatter.prototype
those error objects already have special handling for toString(), so the easiest fix is to extend that same handling to toJSON.
Attachment #8672906 -
Flags: review?(rnewman)
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → markh
|
||
Updated•9 years ago
|
Status: NEW → ASSIGNED
|
|
||
Comment 1•9 years ago
|
||
Comment on attachment 8672906 [details] [diff] [review] 0002-Bug-XXXXXXX-allow-TokenServerClient-errors-to-be-JSO.patch Review of attachment 8672906 [details] [diff] [review]: ----------------------------------------------------------------- LGTM if it works!
Attachment #8672906 -
Flags: review?(rnewman) → review+
|
||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9889cd9a69bd
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
|
||
Updated•7 years ago
|
Product: Core → Firefox
|
||
Updated•7 years ago
|
Target Milestone: mozilla44 → Firefox 44
You need to log in
before you can comment on or make changes to this bug.
Description
•