1214111 - Autophone - tcheck3 analyze_logcat is broken

Status: RESOLVED FIXED

(Testing Graveyard :: Autophone, defect)

Description

[Bob Clary [:bc] (inactive)]

Attachment: tcheck3.patch

The robotest.py analyze_logcat will get stuck in an infinite loop. The attached patch moves things around so the loop doesn't occur but it doesn't get the measurements and needs more work but it is a starting point.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

I need to consider if tcheck is useful:
https://bugzilla.mozilla.org/show_bug.cgi?id=1213032

This test is hard to run reliably, overall, I think it is good, but on a different device it could be problematic.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: https://github.com/mozilla/autophone/pull/43

this patch is what was used to generate data for:
https://treeherder.allizom.org/#/jobs?repo=mozilla-inbound&fromchange=5bdf50e82ca8&tochange=8ca7268d0d1f&filter-searchStr=autophone

Comment 3

[Bob Clary [:bc] (inactive)]

Comment on attachment 8675045 [details] [review]
https://github.com/mozilla/autophone/pull/43

You forgot the analyze_logcat changes.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: https://github.com/mozilla/autophone/pull/44

included the change made in this bug originally!

Comment 5

[Bob Clary [:bc] (inactive)]

Comment on attachment 8675123 [details] [review]
https://github.com/mozilla/autophone/pull/44

r- until we can chat more.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8675123 [details] [review]
https://github.com/mozilla/autophone/pull/44

I have updated the pull request- the last 20 data points of rck3 have all been with the code that is in the pull request.

Comment 7

[Bob Clary [:bc] (inactive)]

Comment on attachment 8675123 [details] [review]
https://github.com/mozilla/autophone/pull/44

Looks good. One thing that would be nice would be to include a link to the perfherder graph in the job details. See https://github.com/mozilla/autophone/blob/master/autophonetreeherder.py#L301 for an example. 

We don't have to do that now though if you don't want.

It would be nice to see additional data points for different builds. Can you keep it running until tomorrow?

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

https://github.com/mozilla/autophone/commit/070d7d5b87ca596d3159ef9fcfa0b044436087e7