1214117 - sync restores deleted history items

Status: NEW

(Firefox :: Sync, defect, P3)

Description

[bzanetti00]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Firefox/38.0 Iceweasel/38.3.0
Build ID: 20150923030055

Steps to reproduce:

Two or more devices are synced with firefox sync. On device A I clear all history items older than six months, the sync icon activates and after a while it stops. Then I close the browser. On device B I start firefox and sync activates. The old history is still there. Then reopen the device A, sync is started.


Actual results:

The deleted history items are restored on device A.


Expected results:

The history should have disappeared from the device B and not restored from it!

Comment 1

[Shane Tomlinson [:stomlinson]]

I see this behavior as well. After the shutdown of `etherpad.mozilla.org`, I went and deleted all `etherpad.mozilla.org` items from history so they would not show up in the awesome bar. After a sync with a second device, `etherpad.mozilla.org` URLs litter my history/awesomebar again.

Comment 2

[Richard Newman [:rnewman]]

IIRC batch deletions are not handled correctly by sync; I expect they wouldn't be tracked. That doesn't explain why they'd come back, though. 

Unless we take a bulk deletion observer and do a full sync, which of course will redownload everything we just deleted…