Cleanup SetPropertyIC::update

RESOLVED FIXED in Firefox 44

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

unspecified
mozilla44
Points:
---

Firefox Tracking Flags

(firefox44 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8673040 [details] [diff] [review]
Patch

SetPropertyIC::update is a bit of a mess and hard to read.

This patch moves the code to attach stubs to a new method, tryAttachStub, and adds separate methods for each type (tryAttachProxy, tryAttachNative, etc), like GetPropertyIC does.

No change in behavior.
Attachment #8673040 - Flags: review?(efaustbmo)
Comment on attachment 8673040 [details] [diff] [review]
Patch

Review of attachment 8673040 [details] [diff] [review]:
-----------------------------------------------------------------

Man, this way is prettier. I remember when I did this for GetPropertyIC. Feels so good.
Attachment #8673040 - Flags: review?(efaustbmo) → review+
https://hg.mozilla.org/mozilla-central/rev/03f521f50792
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.