Closed
Bug 1214234
Opened 8 years ago
Closed 8 years ago
Be explicit about LOAD_URL telemetry from Home Panels
Categories
(Firefox for Android Graveyard :: Awesomescreen, defect)
Firefox for Android Graveyard
Awesomescreen
Tracking
(firefox42 verified, firefox43 verified, firefox44 verified)
VERIFIED
FIXED
Firefox 44
People
(Reporter: mfinkle, Assigned: mfinkle)
Details
Attachments
(1 file)
8.19 KB,
patch
|
liuche
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
We have been using the Session telemetry to figure out the LOAD_URL/LIST_ITEM source panel. This should work fine, but I am a little worried that my post-processing scripts could be getting confused by the fact that we can display Home Panels on top of Home Panels, creating a nesting of panel sessions. I mean, it's OK to open about:home (which creates a Session) and then tap the URL bar (which opens a different Home Panel and creates a different Session). By tagging the Telemetry with an Extra, we can be more accurate.
Attachment #8673141 -
Flags: review?(liuche)
Updated•8 years ago
|
Attachment #8673141 -
Flags: review?(liuche) → review+
Comment 2•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/17bb5573ac93
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Assignee | ||
Comment 3•8 years ago
|
||
Comment on attachment 8673141 [details] [diff] [review] explicit-homepanel-loadurl v0.1 Approval Request Comment [Feature/regressing bug #]: [User impact if declined]: We get more accurate LOAD_URL telemetry and be more sure about which parts fo the app are most active. [Describe test coverage new/current, TreeHerder]: On Nightly [Risks and why]: Low, just added an Extra hint [String/UUID change made/needed]: none
Attachment #8673141 -
Flags: approval-mozilla-beta?
Attachment #8673141 -
Flags: approval-mozilla-aurora?
Updated•8 years ago
|
Comment 4•8 years ago
|
||
Comment on attachment 8673141 [details] [diff] [review] explicit-homepanel-loadurl v0.1 Sure, if that can help you. Should be in 42 beta 8.
Attachment #8673141 -
Flags: approval-mozilla-beta?
Attachment #8673141 -
Flags: approval-mozilla-beta+
Attachment #8673141 -
Flags: approval-mozilla-aurora?
Attachment #8673141 -
Flags: approval-mozilla-aurora+
Verified as fixed on Firefox 42 Beta 8, latest Aurora and Nightly
Status: RESOLVED → VERIFIED
Updated•2 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•