Closed
Bug 1214242
Opened 9 years ago
Closed 9 years ago
Usability improvements to pin dialog
Categories
(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)
Firefox OS Graveyard
Gaia::System::Browser Chrome
ARM
Gonk (Firefox OS)
Tracking
(blocking-b2g:2.5+)
VERIFIED
FIXED
| blocking-b2g | 2.5+ |
People
(Reporter: mikehenrty, Assigned: apastor)
References
Details
(Whiteboard: [systemsfe])
User Story
Visual Spec: https://mozilla.box.com/s/a25ot7ruu5u0mvxjirhrtu8d3rt5r107 Refer to Page 12 (portrait) Refer to Page 19 (Landscape) Image Assets https://mozilla.box.com/s/ncbx9extr6h86s6fx5y2i1z3foccli1b
Attachments
(3 files)
Visual design
Visual spec incoming.
|
Reporter | |
Comment 1•9 years ago
|
||
ni? on Eric to upload visual spec when they are ready.
Flags: needinfo?(epang)
|
||
Updated•9 years ago
|
Summary: Implement Pin Card dialog according to *final* design spec → Usability improvements to pin dialog
|
|
||
Comment 2•9 years ago
|
||
|
|
||
Updated•9 years ago
|
Component: Gaia::System → Gaia::System::Browser Chrome
|
||
Updated•9 years ago
|
QA Whiteboard: [COM=Pin the Web]
|
|
||
Comment 3•9 years ago
|
||
Visual design (pending review, spec to follow)
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → apastor
|
||
Updated•9 years ago
|
User Story: (updated)
Flags: needinfo?(epang)
|
|
Assignee | |
Comment 4•9 years ago
|
||
Let's wait for the unpinning feature before changing the design.
Depends on: 1202571
|
||
Comment 5•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8675251 -
Flags: review?(mhenretty)
|
|
Reporter | |
Comment 6•9 years ago
|
||
Comment on attachment 8675251 [details] [review]
[gaia] albertopq:1214242-new-design-pin > mozilla-b2g:master
Code looks good to me, but when I turn the phone into landscape mode the pin buttons disappear.
Flags: needinfo?(apastor)
Attachment #8675251 -
Flags: review?(mhenretty)
|
|
Reporter | |
Comment 7•9 years ago
|
||
Also, looks like we might have a failing test:
TEST-UNEXPECTED-FAIL | apps/system/test/marionette/app_window_mananger_pinned_sites_test.js | AppWindowManager - Pinning sites "before each" hook
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8675251 -
Flags: review?(mhenretty)
|
|
Reporter | |
Comment 9•9 years ago
|
||
Comment on attachment 8675251 [details] [review]
[gaia] albertopq:1214242-new-design-pin > mozilla-b2g:master
Looks good to me! I'm going to go ahead and merge this so I can rebase bug 1214610 and make sure the tests are green. Thanks!
Attachment #8675251 -
Flags: review?(mhenretty) → review+
|
|
Reporter | |
Comment 10•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
|
||
Comment 11•9 years ago
|
||
Verified on
[Flame]
Build ID 20151019150205
Gaia Revision a87f947366c2e044bd6336e1982419ac45378969
Gaia Date 2015-10-19 15:22:08
Gecko Revision https://hg.mozilla.org/mozilla-central/rev/9605da94e75d61598d3c00f01a12d1b6bc427a6c
Gecko Version 44.0a1
Device Name flame
Firmware(Release) 4.4.2
Firmware(Incremental) eng.cltbld.20151019.182947
Firmware Date Mon Oct 19 18:29:58 EDT 2015
Bootloader L1TC000118D0
[Aries]
Build ID 20151019205841
Gaia Revision a87f947366c2e044bd6336e1982419ac45378969
Gaia Date 2015-10-19 15:22:08
Gecko Revision https://hg.mozilla.org/mozilla-central/rev/9605da94e75d61598d3c00f01a12d1b6bc427a6c
Gecko Version 44.0a1
Device Name aries
Firmware(Release) 4.4.2
Firmware(Incremental) eng.worker.20151019.201730
Firmware Date Mon Oct 19 20:17:38 UTC 2015
Bootloader s1
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•