121431 - nsProfile::LoadDefaultProfileDir() returns error when it shouldn't

Status: VERIFIED FIXED

(Core Graveyard :: Profile: BackEnd, defect)

Description

[Conrad Carlen (not reading bugmail)]

http://lxr.mozilla.org/mozilla/source/profile/src/nsProfile.cpp#620
If the profile is brand new, this will return failure because the pref is not
there. That failure propagates up and, in turbo mode, has the disasterous effect
of failing to create an initial window :-/ Patch coming up.

Comment 1

[Conrad Carlen (not reading bugmail)]

Attachment: patch

This code has been around for a while and I'm not sure why this didn't show up
before. Brian, it was changed to use nsIPrefBranch instead of the ole nsIPref.
Is it possible that nsIPref didn't return failure for a non-existant pref?

Comment 2

[Conrad Carlen (not reading bugmail)]

Since this is a turbo-killer, adding nsbeta1 and want to get it on 0.9.8 wagon.

Comment 3

[Brian Nesse (gone)]

Comment on attachment 66122 [details] [diff] [review]
patch

No, prefs have always returned failure when the pref doesn't exist. Besides
which, nsIPref is just a wrapper which calls nsIPrefBranch... and has been for
some time. More likely is that the error handling was incorrectly added when
the code was converted from nsIPref -> nsIPrefBranch. r=bnesse on the patch.

Comment 4

[Brian Nesse (gone)]

Hmm, that's not it. I just looked at Chip's patch... the error handling was
there before the change to nsIPrefBranch. It would seem that it has been this
way for a long time.

Comment 5

[Conrad Carlen (not reading bugmail)]

CC'ing alecf for sr=

Comment 6

[Alec Flett]

Comment on attachment 66122 [details] [diff] [review]
patch

sr=alecf

Comment 7

[Conrad Carlen (not reading bugmail)]

Checked into trunk - leaving open to get it into 0.9.8.

Comment 8

[Asa Dotzler [:asa]]

a=asa (on behalf of drivers) for checkin to the 0.9.8 branch

Comment 9

[Conrad Carlen (not reading bugmail)]

Checked into branch.

Comment 10

[K'Trina Medina]

Verified code fix