[raptor-regression] Latest ramda introduces breaking change

RESOLVED FIXED in FxOS-S9 (16Oct)

Status

Firefox OS
Gaia::PerformanceTest
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Eli, Assigned: Eli)

Tracking

unspecified
FxOS-S9 (16Oct)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [systemsfe])

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
Going from ramda 0.17 to 0.18 has breaking changes. Correct the changes, and start pinning ramda.
(Assignee)

Comment 1

2 years ago
Created attachment 8673242 [details] [review]
Link to Github pull-request: https://github.com/mozilla-raptor/regression/pull/5
Attachment #8673242 - Flags: review?(rwood)

Comment 2

2 years ago
Comment on attachment 8673242 [details] [review]
Link to Github pull-request: https://github.com/mozilla-raptor/regression/pull/5

LGTM
Attachment #8673242 - Flags: review?(rwood) → review+
(Assignee)

Comment 3

2 years ago
In master: https://github.com/mozilla-raptor/regression/commit/2523826063517bb429d89351185a45f4917a64b4
In npm: raptor-regression v1.0.1
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
(Assignee)

Comment 4

2 years ago
Created attachment 8674288 [details] [review]
Link to Github pull-request: https://github.com/mozilla-raptor/regression/pull/6

Missed a couple changes. ;_;
Assignee: nobody → eperelman
Status: RESOLVED → REOPENED
Attachment #8674288 - Flags: review?(rwood)
Resolution: FIXED → ---

Comment 5

2 years ago
Comment on attachment 8674288 [details] [review]
Link to Github pull-request: https://github.com/mozilla-raptor/regression/pull/6

LGTM
Attachment #8674288 - Flags: review?(rwood) → review+
(Assignee)

Comment 6

2 years ago
In master (again): https://github.com/mozilla-raptor/regression/commit/3bb08718e2a074836b1ce7ad7abbdf84e80076af
In npm (again): raptor-regression v1.0.2
Status: REOPENED → RESOLVED
Last Resolved: 2 years ago2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.