Closed Bug 1214401 Opened 9 years ago Closed 9 years ago

Fix crash reporter check color

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(firefox44 fixed, fennec44+)

RESOLVED FIXED
Firefox 44
Tracking Status
firefox44 --- fixed
fennec 44+ ---

People

(Reporter: mcomella, Assigned: mcomella)

References

Details

Attachments

(5 files)

Screenshot from nalexander – he thinks it's Android 4.4.2.

He said the icons changed from Holo-style to Material style. imo, the fix is to just turn these orange rather than trying to replicate the Holo theme. It's inconsistent with other screens, but it's not shown often so I'm okay with it.

Anthony, do you agree?

I'm not sure why this isn't already taking accentColor.
Flags: needinfo?(alam)
I guess this would fall under the "move to a unified UI" theme - I'm OK with this. But does this go for ALL versions then? i.e. would they all be material? 

I'll have to keep this in mind when we look at updating this entire experience
Flags: needinfo?(alam)
(In reply to Anthony Lam (:antlam) from comment #2)
> I guess this would fall under the "move to a unified UI" theme - I'm OK with
> this. But does this go for ALL versions then? i.e. would they all be
> material? 

That's my expectation – I'll let you know when I can get this building (trying in bug 1194205).
The build in comment 6 crashed at runtime with:
  10-15 09:55:50.727 E/AndroidRuntime( 5358): java.lang.RuntimeException: Unable to start activity ComponentInfo{org.mozilla.fennec/org.mozilla.gecko.CrashReporter}: java.lang.IllegalArgumentException: AppCompat does not support the current theme features: { windowActionBar: false, windowActionBarOverlay: false, android:windowIsFloating: false, windowActionModeOverlay: false, windowNoTitle: false }

I'm going to guess this is because I had windowActionBar & windowNoTitle conflicting as windowNoTitle had an android: prefix (I filed bug 1215198 to prevent this in the future).
NI self to test on 5+. Works on 4.* and 2.3.
Flags: needinfo?(michael.l.comella)
Bug 1214401 - Move accentColor to non-API specific application styles. r=sebastian

We override this in most places so it shouldn't affect the application too much.
Attachment #8674406 - Flags: review?(s.kaspari)
Bug 1214401 - Remove android: prefix from several attributes. r=sebastian

This should make these attributes compatible with Theme.AppCompat.
Attachment #8674408 - Flags: review?(s.kaspari)
Comment on attachment 8674406 [details]
MozReview Request: Bug 1214401 - Move accentColor to non-API specific application styles. r=sebastian

https://reviewboard.mozilla.org/r/22223/#review19893
Attachment #8674406 - Flags: review?(s.kaspari) → review+
Attachment #8674407 - Flags: review?(s.kaspari) → review+
Comment on attachment 8674407 [details]
MozReview Request: Bug 1214401 - Make CrashReporter extend AppCompatActivity. r=sebastian

https://reviewboard.mozilla.org/r/22225/#review19895
Comment on attachment 8674408 [details]
MozReview Request: Bug 1214401 - Remove android: prefix from several attributes. r=sebastian

https://reviewboard.mozilla.org/r/22227/#review19897
Attachment #8674408 - Flags: review?(s.kaspari) → review+
(In reply to Michael Comella (:mcomella) from comment #11)
> NI self to test on 5+. Works on 4.* and 2.3.

Works on 5+.
Flags: needinfo?(michael.l.comella)
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: