Closed
Bug 1214401
Opened 9 years ago
Closed 9 years ago
Fix crash reporter check color
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox44 fixed, fennec44+)
RESOLVED
FIXED
Firefox 44
People
(Reporter: mcomella, Assigned: mcomella)
References
Details
Attachments
(5 files)
Screenshot from nalexander – he thinks it's Android 4.4.2. He said the icons changed from Holo-style to Material style. imo, the fix is to just turn these orange rather than trying to replicate the Holo theme. It's inconsistent with other screens, but it's not shown often so I'm okay with it. Anthony, do you agree? I'm not sure why this isn't already taking accentColor.
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(alam)
Assignee | ||
Comment 1•9 years ago
|
||
Comment 2•9 years ago
|
||
I guess this would fall under the "move to a unified UI" theme - I'm OK with this. But does this go for ALL versions then? i.e. would they all be material? I'll have to keep this in mind when we look at updating this entire experience
Flags: needinfo?(alam)
Assignee | ||
Comment 3•9 years ago
|
||
(In reply to Anthony Lam (:antlam) from comment #2) > I guess this would fall under the "move to a unified UI" theme - I'm OK with > this. But does this go for ALL versions then? i.e. would they all be > material? That's my expectation – I'll let you know when I can get this building (trying in bug 1194205).
Assignee | ||
Comment 4•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b60618d57097
Assignee | ||
Comment 5•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5dc13cf885ef
Assignee | ||
Comment 6•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1f11453ec2b1
Assignee | ||
Comment 7•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=36a23c7cfc35
Comment hidden (typo) |
Assignee | ||
Comment 9•9 years ago
|
||
The build in comment 6 crashed at runtime with: 10-15 09:55:50.727 E/AndroidRuntime( 5358): java.lang.RuntimeException: Unable to start activity ComponentInfo{org.mozilla.fennec/org.mozilla.gecko.CrashReporter}: java.lang.IllegalArgumentException: AppCompat does not support the current theme features: { windowActionBar: false, windowActionBarOverlay: false, android:windowIsFloating: false, windowActionModeOverlay: false, windowNoTitle: false } I'm going to guess this is because I had windowActionBar & windowNoTitle conflicting as windowNoTitle had an android: prefix (I filed bug 1215198 to prevent this in the future).
Assignee | ||
Comment 10•9 years ago
|
||
lgtm!
Assignee | ||
Comment 11•9 years ago
|
||
NI self to test on 5+. Works on 4.* and 2.3.
Flags: needinfo?(michael.l.comella)
Assignee | ||
Comment 12•9 years ago
|
||
Bug 1214401 - Move accentColor to non-API specific application styles. r=sebastian We override this in most places so it shouldn't affect the application too much.
Attachment #8674406 -
Flags: review?(s.kaspari)
Assignee | ||
Comment 13•9 years ago
|
||
Bug 1214401 - Make CrashReporter extend AppCompatActivity. r=sebastian
Attachment #8674407 -
Flags: review?(s.kaspari)
Assignee | ||
Comment 14•9 years ago
|
||
Bug 1214401 - Remove android: prefix from several attributes. r=sebastian This should make these attributes compatible with Theme.AppCompat.
Attachment #8674408 -
Flags: review?(s.kaspari)
Comment 15•9 years ago
|
||
Comment on attachment 8674406 [details] MozReview Request: Bug 1214401 - Move accentColor to non-API specific application styles. r=sebastian https://reviewboard.mozilla.org/r/22223/#review19893
Attachment #8674406 -
Flags: review?(s.kaspari) → review+
Updated•9 years ago
|
Attachment #8674407 -
Flags: review?(s.kaspari) → review+
Comment 16•9 years ago
|
||
Comment on attachment 8674407 [details] MozReview Request: Bug 1214401 - Make CrashReporter extend AppCompatActivity. r=sebastian https://reviewboard.mozilla.org/r/22225/#review19895
Comment 17•9 years ago
|
||
Comment on attachment 8674408 [details] MozReview Request: Bug 1214401 - Remove android: prefix from several attributes. r=sebastian https://reviewboard.mozilla.org/r/22227/#review19897
Attachment #8674408 -
Flags: review?(s.kaspari) → review+
Assignee | ||
Comment 18•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/1b670533096ab5b51e34e0f667f13a8ec112d0b2 Bug 1214401 - Move accentColor to non-API specific application styles. r=sebastian https://hg.mozilla.org/integration/fx-team/rev/4d660e11add4f9dc48e7658869d06a1f203153f3 Bug 1214401 - Make CrashReporter extend AppCompatActivity. r=sebastian https://hg.mozilla.org/integration/fx-team/rev/99f0ffcc569040bd68d005bbacd77db68b0568a5 Bug 1214401 - Remove android: prefix from several attributes. r=sebastian
Comment 19•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1b670533096a https://hg.mozilla.org/mozilla-central/rev/4d660e11add4 https://hg.mozilla.org/mozilla-central/rev/99f0ffcc5690
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Assignee | ||
Comment 20•9 years ago
|
||
(In reply to Michael Comella (:mcomella) from comment #11) > NI self to test on 5+. Works on 4.* and 2.3. Works on 5+.
Flags: needinfo?(michael.l.comella)
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•