Closed
Bug 1214448
Opened 10 years ago
Closed 10 years ago
Always log nextupdate time in Safe Browsing debugging
Categories
(Toolkit :: Safe Browsing, defect)
Toolkit
Safe Browsing
Tracking
()
RESOLVED
FIXED
mozilla44
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | fixed |
People
(Reporter: francois, Assigned: francois)
References
Details
Attachments
(1 file)
|
1.30 KB,
patch
|
gcp
:
review+
|
Details | Diff | Splinter Review |
Bug 1175562 made initial list downloads happen at a random time between 0 and 5 minutes after startup.
Unfortunately the debug log message that shows when that is going to take place doesn't work on the initial download.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8673473 -
Flags: review?(gpascutto)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8673473 [details] [diff] [review]
bug1214448.patch
Review of attachment 8673473 [details] [diff] [review]:
-----------------------------------------------------------------
::: toolkit/components/url-classifier/content/listmanager.js
@@ +235,5 @@
> updateDelay = Math.max(0, nextUpdate - Date.now());
> log("Next update at " + nextUpdate
> + " which is " + updateDelay + "ms from now");
> + } else {
> + log("Next update " + updateDelay + "ms from now");
Pull this out of the if and remove the duplicated part in the other part of the if. Just log two lines.
IMHO that makes the control flow easier to follow.
Attachment #8673473 -
Flags: review?(gpascutto) → review+
|
||
Comment 4•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•