1214448 - Always log nextupdate time in Safe Browsing debugging

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[François Marier [:francois]]

Bug 1175562 made initial list downloads happen at a random time between 0 and 5 minutes after startup.

Unfortunately the debug log message that shows when that is going to take place doesn't work on the initial download.

Comment 1

[François Marier [:francois]]

Attachment: bug1214448.patch

Comment 2

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 8673473 [details] [diff] [review]
bug1214448.patch

Review of attachment 8673473 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/url-classifier/content/listmanager.js
@@ +235,5 @@
>          updateDelay = Math.max(0, nextUpdate - Date.now());
>          log("Next update at " + nextUpdate
>              + " which is " + updateDelay + "ms from now");
> +      } else {
> +        log("Next update " + updateDelay + "ms from now");

Pull this out of the if and remove the duplicated part in the other part of the if. Just log two lines.

IMHO that makes the control flow easier to follow.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c84c350db752

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c84c350db752