1214495 - Move CallerSubsumes checks in nsLocation into the WebIDL entry points

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Bobby Holley (:bholley)]

This will solve crashes like:

https://crash-stats.mozilla.com/report/index/19620496-7bb9-4dc6-b6af-be50c2151014

Comment 2

[Liz Henry (:lizzard) (relman/hg->git project)]

The crashes reported in bug 1214877 just recently appeared in 44 (both Firefox and Thunderbird). 

Looks like it first showed up in builds 2015092603 and 2015101303. It is often a startup crash. 

More reports: https://crash-stats.mozilla.com/report/list?product=Firefox&signature=nsContentUtils%3A%3ASubjectPrincipal%28%29#tab-sigsummary

Crashing thread:

0 	xul.dll 	nsContentUtils::SubjectPrincipal() 	dom/base/nsContentUtils.cpp
1 	xul.dll 	nsLocation::CallerSubsumes() 	dom/base/nsLocation.cpp
2 	xul.dll 	nsLocation::GetHref(nsAString_internal&) 	dom/base/nsLocation.cpp
3 	xul.dll 	nsNativeAppSupportWin::HandleDDENotification(unsigned int, unsigned int, HCONV__*, HSZ__*, HSZ__*, HDDEDATA__*, unsigned __int64, unsigned __int64) 	toolkit/xre/nsNativeAppSupportWin.cpp
4 	user32.dll 	DoCallback 	
5 	xul.dll 	xul.dll@0x1c1590f 	
6 	user32.dll 	SvSpontRequest 	
7 	ntdll.dll 	RtlActivateActivationContextUnsafeFast 	
8 	user32.dll 	ProcessSyncDDEMessage 	
9 	user32.dll 	DDEMLClientWndProc 	
10 	user32.dll 	ProcessAsyncDDEMsg 	
11 	xul.dll 	nsWindow::WindowProc(HWND__*, unsigned int, unsigned __int64, __int64) 	widget/windows/nsWindow.cpp

Comment 4

[Bobby Holley (:bholley)]

Attachment: Move CallerSubsumes checks in nsLocation into the WebIDL entry points. v1

Comment 5

[Bobby Holley (:bholley)]

Attachment: Bonus fix. v1

This should have been done in bug 839867.

Comment 6

[Bobby Holley (:bholley)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=085bdb2221af

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8673904 [details] [diff] [review]
Move CallerSubsumes checks in nsLocation into the WebIDL entry points. v1

r=me

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8673905 [details] [diff] [review]
Bonus fix. v1

r=me

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6d1f265f7a72
https://hg.mozilla.org/integration/mozilla-inbound/rev/ce5af026e369

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6d1f265f7a72
https://hg.mozilla.org/mozilla-central/rev/ce5af026e369