12145 - [PP] Mac - menu items shouldn't interpret meta characters

Status: VERIFIED FIXED

(Core :: XUL, defect, P2)

Description

[Robert John Churchill]

On Mac, Menu items that start with open parenthesis "(" are disabled, and if
they contain a slash "/" followed by a character have a cmd-key assigned to
them.

Menu items need to be created so that they don't have any meta-character
interpretation.

Comment 1

[cpratt]

This seems vaguely like a duplicate, but I can't substantiate that claim.

Comment 2

[saari (gone)]

My bad, debug code that shouldn't have been checked in. All better now.

Comment 3

[cpratt]

OK, sounds good. How do I verify this, saari?

Comment 4

[saari (gone)]

In navigator.xul pick a menu or menuitem and change its value to some thing that

includes a "(" like value="(foo"

Comment 5

[cpratt]

I'm going to go ahead and admit I can't figure out how to verify this.
Reassigning to elig. (SimpleText couldn't open that file as it was too big; Word
98 seemed to munge it on open, and I don't have a copy of BBEdit or what have
you. May you have better luck! Thanks.)

Comment 6

[Eli Goldberg]

Chris Saari very kindly and patiently explained how to verify this. (thanks!)

In short, using yesterday's optimized Mac build (and whatever debug build saari
had) we:
	- opened the navigatorOverlay.xul in BBEdit
	- replaced menuitem values with ones including metacharacters "/foo" and
"(foo")
	- confirmed that the "/" and "(" characters were displayed, rather than
interpreted.

So, verified.

Comment 7

[leger]

Moving all UE/UI bugs to new component: User Interface: Design Feedback
UE/UI component will be deleted.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/021a00250046
[components] Issue https://github.com/mozilla-mobile/android-components/issues/12145 - Fix strings for save credit card dialog