1214505 - [EME] Backout bug 1209385 from aurora and beta

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

We should back out bug 1209385 from Aurora and beta. I was able to reproduce the particular CDM hang that was causing issue, and the functionality added to crash hung plugins wasn't able to crash the GMP when it was hung.

This is because the CDM had hung its IPC message channel thread.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch: Aurora backout bug 1209385

Approval Request Comment
[Feature/regressing bug #]: Requesting to backout bug 1209385 from Aurora.
[User impact if declined]: bug 1209385 added the ability to crash EME plugins when they're not responsive. However I was able to reproduce an unresponsive plugin, and my patch from bug 1209385 was unable to crash it. We may however unnecessarily crash a plugin when the CPU us under heavy load (I have reproduced this). In this case the GMP may have been able to respond, and crashing it isn't helpful.
[Describe test coverage new/current, TreeHerder]: We have lots of EME tests.
[Risks and why]: Low; this is a backout.
[String/UUID change made/needed]: None.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch: Beta backout bug 1209385

Approval Request Comment
[Feature/regressing bug #]: Requesting to backout bug 1209385 from Beta.
[User impact if declined]: bug 1209385 added the ability to crash EME plugins when they're not responsive. However I was able to reproduce an unresponsive plugin, and my patch from bug 1209385 was unable to crash it. We may however unnecessarily crash a plugin when the CPU us under heavy load (I have reproduced this). In this case the GMP may have been able to respond, and crashing it isn't helpful.
[Describe test coverage new/current, TreeHerder]: We have lots of EME tests.
[Risks and why]: Low; this is a backout.
[String/UUID change made/needed]: None.

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8673495 [details] [diff] [review]
Patch: Aurora backout bug 1209385

Thanks, appreciated it.
Taking it. Should be in 42 beta 7

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/aa99936362c2 setting the flag for chris

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/435d2901f5b5