Closed Bug 1214505 Opened 4 years ago Closed 4 years ago

[EME] Backout bug 1209385 from aurora and beta

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
firefox42 --- fixed
firefox43 --- fixed

People

(Reporter: cpearce, Assigned: cpearce)

Details

Attachments

(2 files)

We should back out bug 1209385 from Aurora and beta. I was able to reproduce the particular CDM hang that was causing issue, and the functionality added to crash hung plugins wasn't able to crash the GMP when it was hung.

This is because the CDM had hung its IPC message channel thread.
Approval Request Comment
[Feature/regressing bug #]: Requesting to backout bug 1209385 from Aurora.
[User impact if declined]: bug 1209385 added the ability to crash EME plugins when they're not responsive. However I was able to reproduce an unresponsive plugin, and my patch from bug 1209385 was unable to crash it. We may however unnecessarily crash a plugin when the CPU us under heavy load (I have reproduced this). In this case the GMP may have been able to respond, and crashing it isn't helpful.
[Describe test coverage new/current, TreeHerder]: We have lots of EME tests.
[Risks and why]: Low; this is a backout.
[String/UUID change made/needed]: None.
Attachment #8673495 - Flags: review+
Attachment #8673495 - Flags: approval-mozilla-aurora?
Approval Request Comment
[Feature/regressing bug #]: Requesting to backout bug 1209385 from Beta.
[User impact if declined]: bug 1209385 added the ability to crash EME plugins when they're not responsive. However I was able to reproduce an unresponsive plugin, and my patch from bug 1209385 was unable to crash it. We may however unnecessarily crash a plugin when the CPU us under heavy load (I have reproduced this). In this case the GMP may have been able to respond, and crashing it isn't helpful.
[Describe test coverage new/current, TreeHerder]: We have lots of EME tests.
[Risks and why]: Low; this is a backout.
[String/UUID change made/needed]: None.
Attachment #8673497 - Flags: review+
Attachment #8673497 - Flags: approval-mozilla-beta?
Comment on attachment 8673495 [details] [diff] [review]
Patch: Aurora backout bug 1209385

Thanks, appreciated it.
Taking it. Should be in 42 beta 7
Attachment #8673495 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8673497 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
https://hg.mozilla.org/releases/mozilla-beta/rev/435d2901f5b5
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.