Closed
Bug 1214530
Opened 9 years ago
Closed 9 years ago
Autophone - do not repeat wait-for-device in adb commands
Categories
(Testing Graveyard :: Autophone, defect)
Testing Graveyard
Autophone
Tracking
(firefox44 affected)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | affected |
People
(Reporter: bc, Assigned: bc)
References
Details
Attachments
(1 file)
|
1.07 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
In recent versions of adb, repeated uses of wait-for-device will result in a syntax error and an exit code of 1. This is a problem for adb_android.py's reboot and is_device_ready methods since adb.py's command_output automatically inserts a wait-for-device into the command. The solution is to just pass an empty argument array which will result in a command adb -s <serial> wait-for-device instead of adb -s <serial> wait-for-device wait-for-device.
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8673528 -
Flags: review?(jmaher)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8673528 [details] [diff] [review] bug-1214530-do-not-repeat-wait-for-device.patch Review of attachment 8673528 [details] [diff] [review]: ----------------------------------------------------------------- seems harmless
Attachment #8673528 -
Flags: review?(jmaher) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
https://github.com/mozilla/autophone/commit/51f541209460ac7487c219b98c79b1ab850eb0e0
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
||
Updated•2 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•