1214546 - [Clock]The ‘Start‘ button is grey and you can't change time picker in 'Timer' to the dedault setting.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[Jessica]

Attachment: logcat_1533.txt

[1.Description]:
[Flame KK v2.5][Aries KK v2.5][Clock] The ‘Start‘ button is gry after you reopen clock app, and you can't change time picker in ’Timer‘ to the dedault setting any more.
Time: 15:33
See attachments: Aries KK v2.5.3gp and logcat_1533.txt

[2.Testing Steps]: 
Precondition: You haven't changed settings in 'Timer' of clock before.
1.Launch clock app and switch to ’Timer‘ view, change time picker in 'Timer'.
2.Close the 'Clock' app by the task manager, and re-open clock app to check the 'Timer' settings.
3.Reset time picker in 'Timer' to the default (0:00).
4.Repeat step 2.

[3.Expected Result]: 
Step 2.‘Start' button shouldn't be grey.
Step 4.It should show 0:00, and ‘Start‘ button is grey.

[4.Actual Result]: 
Step 2.The ‘Start’ button is grey.
Step 4.It still shows the time picker you selected in step 1 and ‘Start‘ button is grey.

[5.Reproduction build]: 
Device: Flame KK v2.5 (Affected)
Build ID               20151013150203
Gaia Revision          d400cda6bf0f8b30dcf7d7d71bfa61f29a3f1588
Gaia Date              2015-10-13 06:42:17
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/2387ada864282880d3a498d643abe3d8b887ee59
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151013.182615
Firmware Date          Tue Oct 13 18:26:27 EDT 2015
Fireware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK v2.5 (Affected)
Build ID               20151013181426
Gaia Revision          d400cda6bf0f8b30dcf7d7d71bfa61f29a3f1588
Gaia Date              2015-10-13 06:42:17
Gecko Revision         https://hg.mozilla.org/integration/mozilla-inbound/rev/2387ada864282880d3a498d643abe3d8b887ee59
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151013.174418
Firmware Date          Tue Oct 13 17:44:27 UTC 2015
Bootloader             s1


[6.Reproduction Frequency]: 
Always Recurrence,10/10

[7.TCID]: 
Free test

[8.Note]:
When user changes time picker in the 'Timer' and leaves the app, settings are forgotten on Flame KK v2.2. So this bug can't be reproed on Flame KK v2.2. And it is blocked by bug 1187314
See bug https://bugzilla.mozilla.org/show_bug.cgi?id=1187314

Comment 1

[Jessica]

Attachment: Aries KK v2.5.3gp

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] mcav:clock-defaults-enable > mozilla-b2g:master

Comment 3

[Marcus Cavanaugh [:mcav]]

Comment on attachment 8673689 [details] [review]
[gaia] mcav:clock-defaults-enable > mozilla-b2g:master

One more tiny one, since you reviewed the patch for defaults...

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8673689 [details] [review]
[gaia] mcav:clock-defaults-enable > mozilla-b2g:master

LGTM

Comment 5

[Marcus Cavanaugh [:mcav]]

master: https://github.com/mozilla-b2g/gaia/commit/bbe5eae63fb338085de71601152d1b5d22a09a4b

Comment 6

[Norry.L.F(Leave from Mozilla)]

Hi Jessica,

Verifyme please.

Comment 7

[Jessica]

Attachment: verified_Aries KK v2.5.3gp

According to the STR of Comment 0, this bug has been verified as fail on latest Flame KK v2.5 and Aries KK v2.5.

See attachments: verified_Aries KK v2.5.3gp and logcat_0033.txt
Reproduce rate: 6/6

Actual results: Step 3.'Start'button is high light.
                Step 4. It still shows the time picker you selected in step 1.

Device: Flame KK v2.5 (Fail)
Build ID               20151019150205
Gaia Revision          a87f947366c2e044bd6336e1982419ac45378969
Gaia Date              2015-10-19 15:22:08
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/9605da94e75d61598d3c00f01a12d1b6bc427a6c
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151019.182947
Firmware Date          Mon Oct 19 18:29:58 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0


Device: Aries KK v2.5 (Fail)
Build ID               20151019205841
Gaia Revision          a87f947366c2e044bd6336e1982419ac45378969
Gaia Date              2015-10-19 15:22:08
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/9605da94e75d61598d3c00f01a12d1b6bc427a6c
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151019.201730
Firmware Date          Mon Oct 19 20:17:38 UTC 2015
Bootloader             s1

Comment 8

[Jessica]

Attachment: logcat_0033.txt

Comment 9

[Jessica]

Hi Marcus,
Please check this issue again. Thank you very much.

Comment 10

[Marcus Cavanaugh [:mcav]]

Hi Jessica,

The STR in Comment 0 are not correct. The bug fixed here is that the Start button should be highlighted when the app is restarted. Because we have now implemented bug 1187314, the timer will _not_ show the original time; it should show the time you last used.

The correct STR should be:

1. Launch clock app and switch to ’Timer‘ view, change time picker in 'Timer'.
2. Close the 'Clock' app by the task manager, and re-open clock app to check the 'Timer' settings.
3. The timer should be the same time you selected in #1.
4. The Start button should be blue (clickable).

Comment 11

[Pi Wei Cheng [:piwei] (inactive)]

verifyme tag is not needed because comment 7 has already done the task.

Comment 12

[Jessica]

Hi Marcus,

The results of the step which you provided is pass,  the special step is that if we change the time from any other[EX: 0:06] to 0:00, the start button is still hilighted [It should be disabled, right?], and then relaunch clock->select timer,  it won't keep on 0:00, 0:06 is displayed, do you think this is an issue?

Comment 13

[Marcus Cavanaugh [:mcav]]

I see. After investigation, that's bug 1157621, where the button doesn't always update (and save the timer state) depending on how you move your fingers on the time picker. I'll fix that in bug 1157621.

Comment 14

[Jessica]

Attachment: verified_Aries KK v2.5.3gp

According to the STR of Comment 0, this bug has been verified as pass on latest build of Flame KK v2.5&v2.6 512mb and Aries KK v2.5&v2.6.

Actual results: Step 3.'Start'button is grey.
                Step 4.It shows 0:00, and ‘Start‘ button is grey.      

See attachment: verified_Aries KK v2.5.3gp
Reproduce rate: 0/6


Device: Flame KK v2.5 512mb (Pass)
Build ID               20151116173604
Gaia Revision          9473dbcbebf4e758a3b73200968efc69071b4312
Gaia Date              2015-11-16 15:49:25
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/17877d161e5f62726027ee70101a7004dcad5a69
Gecko Version          44.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151116.164743
Firmware Date          Mon Nov 16 16:47:52 UTC 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Flame KK v2.6 512mb (master)(Pass)
Build ID               20151116150206
Gaia Revision          e8c15ae4e5324a210000ee0a869a962aa542009f
Gaia Date              2015-11-13 00:10:48
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/d1cae7deae1ac0aa4c2a4b1aca1f3b6966fa58b4
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151116.203255
Firmware Date          Mon Nov 16 20:33:07 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK v2.5 (Pass)
Build ID               20151116174534
Gaia Revision          9473dbcbebf4e758a3b73200968efc69071b4312
Gaia Date              2015-11-16 15:49:25
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/17877d161e5f62726027ee70101a7004dcad5a69
Gecko Version          44.0a2
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151116.165317
Firmware Date          Mon Nov 16 16:53:25 UTC 2015
Bootloader             s1

Device: Aries KK v2.6 (master)(Pass)
Build ID               20151112120735
Gaia Revision          27bc9412ca607648bc398b25bb1ae25653b2b278
Gaia Date              2015-11-12 02:27:47
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/3cc3b1968524248450c465c4ea2ee5596ffa65f2
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151112.112635
Firmware Date          Thu Nov 12 11:26:43 UTC 2015
Bootloader             s1