Closed Bug 1214570 Opened 9 years ago Closed 9 years ago

Skip call to _initFxSyncWebCrypto if options.adapters is empty in SyncEngine

Categories

(Firefox OS Graveyard :: Sync, defect, P3)

Product:
Firefox OS Graveyard
Component:
Sync
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
FxOS-S11 (13Nov)

People

(Reporter: mbdejong, Assigned: mbdejong)

References

Details

Attachments

(1 file)

[gaia] michielbdejong:1214570-skip-initfxsyncwebcrypto > mozilla-b2g:master
46 bytes, text/x-github-pull-request
ferjm
: review+
Details | Review 
There is no need to call to _initFxSyncWebCrypto [1] if options.adapters [2] is empty. This may occur if the system app wants to know if crypto/keys exists for the current account, but doesn't want to sync any collections yet.

[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/sync/js/sync-engine/syncengine.js#L323-L333
[2] https://github.com/mozilla-b2g/gaia/blob/master/apps/sync/js/sync-engine/syncengine.js#L151-L153
Assignee: nobody → mbdejong
Blocks: 1195647
Blocks: fxos-sync
Target Milestone: --- → FxOS-S9 (16Oct)
Target Milestone: FxOS-S9 (16Oct) → FxOS-S10 (30Oct)
Priority: -- → P2
Priority: P2 → P3
Target Milestone: FxOS-S10 (30Oct) → FxOS-S11 (13Nov)
Attachment #8686018 - Flags: review?(ferjmoreno)
https://github.com/mozilla-b2g/gaia/commit/1ec89cb57b5e48d504631962180de37bbdff9635
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Attachment #8686018 - Flags: review?(ferjmoreno) → review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: