Closed
Bug 1214579
Opened 9 years ago
Closed 9 years ago
navbar items all have different heights on OS X retina
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
Firefox 44
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | fixed |
People
(Reporter: Gijs, Assigned: Gijs)
References
Details
Attachments
(2 files)
|
401.87 KB,
image/png
|
Details | |
|
978 bytes,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
Screenshot
This is on current fx-team tip, so it includes all the other followup fixes, but it looks completely busted. I don't understand why yet. I was under the impression this was supposed to have been fixed in bug 1214244, but it doesn't seem to have been.
|
Assignee | |
Comment 1•9 years ago
|
||
It looks like this is because there is no width or height being set on the back/fwd buttons at all, and on retina their imagery is too big, and so now they stretch because of that, leading to all the other bustage.
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•9 years ago
|
Summary: navbar items all have different heights on OS X → navbar items all have different heights on OS X retina
|
|
Assignee | |
Comment 2•9 years ago
|
||
Attachment #8673608 -
Flags: review?(dao)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8673608 [details] [diff] [review] fix styling of back/fwd (and thereby navbar items) on OS X retina screens, Thanks. Too bad toolbarbutton-1 and the back / forward styling are so different on OS X. Maybe we should fix that, and maybe I should also finally get my own Mac to catch these kind of issues earlier...
Attachment #8673608 -
Flags: review?(dao) → review+
|
||
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/dc3f5e4b8f31
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
You need to log in
before you can comment on or make changes to this bug.
Description
•