navbar items all have different heights on OS X retina

RESOLVED FIXED in Firefox 44

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Gijs, Assigned: Gijs)

Tracking

Trunk
Firefox 44
Points:
---

Firefox Tracking Flags

(firefox44 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
Created attachment 8673607 [details]
Screenshot

This is on current fx-team tip, so it includes all the other followup fixes, but it looks completely busted. I don't understand why yet. I was under the impression this was supposed to have been fixed in bug 1214244, but it doesn't seem to have been.
(Assignee)

Comment 1

3 years ago
It looks like this is because there is no width or height being set on the back/fwd buttons at all, and on retina their imagery is too big, and so now they stretch because of that, leading to all the other bustage.
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
(Assignee)

Updated

3 years ago
Summary: navbar items all have different heights on OS X → navbar items all have different heights on OS X retina
(Assignee)

Comment 2

3 years ago
Created attachment 8673608 [details] [diff] [review]
fix styling of back/fwd (and thereby navbar items) on OS X retina screens,
Attachment #8673608 - Flags: review?(dao)
Comment on attachment 8673608 [details] [diff] [review]
fix styling of back/fwd (and thereby navbar items) on OS X retina screens,

Thanks. Too bad toolbarbutton-1 and the back / forward styling are so different on OS X. Maybe we should fix that, and maybe I should also finally get my own Mac to catch these kind of issues earlier...
Attachment #8673608 - Flags: review?(dao) → review+
https://hg.mozilla.org/mozilla-central/rev/dc3f5e4b8f31
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox44: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
You need to log in before you can comment on or make changes to this bug.