Closed Bug 1214593 Opened 4 years ago Closed 4 years ago

Remove service worker periodic updater

Categories

(Core :: DOM: Service Workers, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox44 --- affected
firefox45 --- fixed
b2g-v2.5 --- fixed

People

(Reporter: dimi, Assigned: dimi)

References

Details

Attachments

(1 file, 4 obsolete files)

Bug 1207727 will implement the new update algorithm according to latest spec.
We can remove periodic updater after new update algorithm is applied
Depends on: 1207727
Assignee: nobody → dlee
Status: NEW → ASSIGNED
Thanks Dimi!  I can also easily prepare a code removal patch since I wrote it originally.  Please let me know if you ant help!  :-)
(In reply to Ehsan Akhgari (don't ask for review please) from comment #1)
> Thanks Dimi!  I can also easily prepare a code removal patch since I wrote
> it originally.  Please let me know if you ant help!  :-)
Hi Ehsan, it would be nice to have that patch :)
Thanks for help!
Attached patch Patch - remove periodic updater (obsolete) — Splinter Review
Looks like you already have the patch.  :-)
Hi Ehsan,
Do you know who can help review this ? Thanks!
Flags: needinfo?(ehsan)
I think bkelly or myself.
Flags: needinfo?(ehsan)
(Or baku!)
Comment on attachment 8679294 [details] [diff] [review]
Patch - remove periodic updater

Review of attachment 8679294 [details] [diff] [review]:
-----------------------------------------------------------------

HI Eshan,
If you have time could you help review this since you wrote it :)
If you are too busy i will find ben or baku to help on this, thanks!
Attachment #8679294 - Flags: review?(ehsan)
Comment on attachment 8679294 [details] [diff] [review]
Patch - remove periodic updater

Review of attachment 8679294 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, thank you!
Attachment #8679294 - Flags: review?(ehsan) → review+
(In reply to Dimi Lee[:dimi][:dlee] from comment #9)
> HI Eshan,

s/sh/hs/, btw.  :-)
(In reply to Ehsan Akhgari (don't ask for review please) [Away Nov 3-19] from comment #11)
> (In reply to Dimi Lee[:dimi][:dlee] from comment #9)
> > HI Eshan,
> 
> s/sh/hs/, btw.  :-)

Ah, sorry, won't happen again! :)
-Rebase to latest code
Attachment #8679294 - Attachment is obsolete: true
Attachment #8681010 - Flags: review+
try result is in Comment 4
Keywords: checkin-needed
Hi, this failed to apply:

patching file dom/workers/ServiceWorkerManager.cpp
Hunk #1 FAILED at 4017
1 out of 1 hunks FAILED -- saving rejects to file dom/workers/ServiceWorkerManager.cpp.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and refresh bug_1214593.patch
Flags: needinfo?(dlee)
Keywords: checkin-needed
rebase patch
Attachment #8681010 - Attachment is obsolete: true
Flags: needinfo?(dlee)
Attachment #8681750 - Flags: review+
Keywords: checkin-needed
Comment on attachment 8681750 [details] [diff] [review]
Patch - remove periodic updater v3

forget update patch description
Attachment #8681750 - Attachment is obsolete: true
Keywords: checkin-needed
add bug description
Attachment #8681753 - Flags: review+
Keywords: checkin-needed
Hi Dimi, this still failed to apply, different file this time:

renamed 1214593 -> bug_1214593.patch
applying bug_1214593.patch
patching file dom/workers/ServiceWorkerPeriodicUpdater.cpp
Hunk #1 FAILED at 0
1 out of 1 hunks FAILED -- saving rejects to file dom/workers/ServiceWorkerPeriodicUpdater.cpp.rej
Flags: needinfo?(dlee)
Keywords: checkin-needed
rebase again
Attachment #8681753 - Attachment is obsolete: true
Attachment #8681809 - Flags: review+
(In reply to Carsten Book [:Tomcat] from comment #19)
> Hi Dimi, this still failed to apply, different file this time:
> 
> renamed 1214593 -> bug_1214593.patch
> applying bug_1214593.patch
> patching file dom/workers/ServiceWorkerPeriodicUpdater.cpp
> Hunk #1 FAILED at 0
> 1 out of 1 hunks FAILED -- saving rejects to file
> dom/workers/ServiceWorkerPeriodicUpdater.cpp.rej

Sorry i rebase to latest inbound again,could you help check in ? thanks!
Flags: needinfo?(dlee)
Keywords: checkin-needed
thanks! this time it worked great. Landed !
https://hg.mozilla.org/mozilla-central/rev/b18e03d64493
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.