Closed
Bug 1214597
Opened 10 years ago
Closed 10 years ago
Some WebCrypto API tests don't check the result of verify() calls
Categories
(Core :: DOM: Security, defect)
Core
DOM: Security
Tracking
()
RESOLVED
FIXED
mozilla44
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | fixed |
People
(Reporter: ttaubert, Assigned: ttaubert)
Details
Attachments
(1 file)
|
4.77 KB,
patch
|
mt
:
review+
|
Details | Diff | Splinter Review |
complete(that) will successfully complete the test when it's called, no matter the value passed to it.
complete(that, x => x) will pass its first argument to the function given as the second argument. Only if that function returns true the test succeeds.
As .verify() doesn't throw but resolve to false when the verification fails, we need to pass a validation function to complete().
| Assignee | ||
Updated•10 years ago
|
Summary: Some WebCrypto API tests don't really check the result of verify() calls → Some WebCrypto API tests don't check the result of verify() calls
| Assignee | ||
Comment 1•10 years ago
|
||
The only test failure we missed was in test_WebCrypto_ECDSA.html, where wrong algorithm parameters were given. All others run fine.
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
Attachment #8673621 -
Flags: review?(martin.thomson)
Updated•10 years ago
|
Attachment #8673621 -
Flags: review?(martin.thomson) → review+
Comment 3•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•