Closed
Bug 1214607
Opened 9 years ago
Closed 9 years ago
Implement empty state of pinned pages panel
Categories
(Firefox OS Graveyard :: Gaia::Homescreen, defect)
Tracking
(blocking-b2g:2.5+)
VERIFIED
FIXED
| blocking-b2g | 2.5+ |
People
(Reporter: cwiiis, Assigned: cwiiis)
References
Details
(Whiteboard: [systemsfe])
User Story
Visual Spec: https://mozilla.box.com/s/a25ot7ruu5u0mvxjirhrtu8d3rt5r107 Refer to Page 26 Empty Home Screen Image Assets: https://mozilla.box.com/s/9c3vfdrff11y14x5xrkf66kp51ot4o15
Attachments
(3 files)
[visual spec]
Currently when you start the homescreen and there are no pinned pages, we hide the panel. If you pin a page and then unpin it (so that there are no pinned pages again), the panel isn't hidden and remains blank.
I purposefully didn't deal with this in bug 1168969, as I believe UX had plans to show something in the pinned pages panel when there are no pinned pages (as opposed to hiding it). Opening this bug to track either that, or hiding the page again if we decide that's what we want to do.
cc'ing some UX peeps for comment.
|
||
Updated•9 years ago
|
blocking-b2g: --- → 2.5+
Whiteboard: [systemsfe]
|
||
Comment 2•9 years ago
|
||
Visual design, pending review. Spec to follow.
|
|
||
Updated•9 years ago
|
Summary: Unpinning the last page results in an empty screen → Implement empty state of pinned pages panel
|
||
Updated•9 years ago
|
User Story: (updated)
Flags: needinfo?(epang)
|
||
Updated•9 years ago
|
QA Whiteboard: [COM=Pin the Web]
|
||
Comment 3•9 years ago
|
||
|
Assignee | |
Updated•9 years ago
|
Attachment #8674277 -
Flags: review?(gmarty)
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8674277 [details] [review]
[gaia] Cwiiis:bug1214607-new-homescreen-empty-pinned-pages > mozilla-b2g:master
I wish we were using SVG for the assets here, but PNG are good enough.
R+!
Attachment #8674277 -
Flags: review?(gmarty) → review+
|
|
Assignee | |
Comment 5•9 years ago
|
||
Spoken to Eric about getting an svg, let's address it in follow-up if it's possible :)
Merged: https://github.com/mozilla-b2g/gaia/commit/9e9c27094e1f72f475c99c152532232112a60057
Assignee: nobody → chrislord.net
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
|
||
Comment 7•9 years ago
|
||
Verified on
[Flame]
Build ID 20151018150205
Gaia Revision f75a7e01912cee313fed92ff2089586f507b2ba5
Gaia Date 2015-10-16 13:00:48
Gecko Revision https://hg.mozilla.org/mozilla-central/rev/d1a89632277fbaaf470c90a35573776048988f2d
Gecko Version 44.0a1
Device Name flame
Firmware(Release) 4.4.2
Firmware(Incremental) eng.cltbld.20151018.183443
Firmware Date Sun Oct 18 18:34:55 EDT 2015
Bootloader L1TC000118D0
[Aries]
Build ID 20151018193102
Gaia Revision f75a7e01912cee313fed92ff2089586f507b2ba5
Gaia Date 2015-10-16 13:00:48
Gecko Revision https://hg.mozilla.org/mozilla-central/rev/d1a89632277fbaaf470c90a35573776048988f2d
Gecko Version 44.0a1
Device Name aries
Firmware(Release) 4.4.2
Firmware(Incremental) eng.worker.20151018.185054
Firmware Date Sun Oct 18 18:51:02 UTC 2015
Bootloader s1
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•