Closed
Bug 1214619
Opened 9 years ago
Closed 9 years ago
Remove nsISaveAsCharset as much as possible without breaking extensions in popular use
Categories
(Core :: Internationalization, defect)
Core
Internationalization
Tracking
()
RESOLVED
FIXED
mozilla45
Tracking | Status | |
---|---|---|
firefox45 | --- | fixed |
People
(Reporter: hsivonen, Assigned: hsivonen)
References
Details
(Keywords: addon-compat, dev-doc-needed)
Attachments
(1 file, 2 obsolete files)
19.29 KB,
patch
|
emk
:
review+
|
Details | Diff | Splinter Review |
Ideally, we should fix bug 1202362, but that would break https://addons.mozilla.org/en-US/firefox/addon/custom-buttons/ (and a couple of addons that only have a handful of users). For now, let's do something that gets rid of the crufty code in nsSaveAsCharset but avoids drama with custom-buttons.
Assignee | ||
Comment 1•9 years ago
|
||
This patch breaks c-c. Hence, the dependency on bug 1202401.
Assignee | ||
Comment 2•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b8d601aada62
Assignee | ||
Comment 3•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d001e3b90e58
Assignee | ||
Comment 4•9 years ago
|
||
Attachment #8673642 -
Attachment is obsolete: true
Assignee | ||
Comment 5•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d5a4a09fab60
Assignee | ||
Comment 6•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ac0ef6fde8c9
Assignee | ||
Comment 7•9 years ago
|
||
Attachment #8676098 -
Attachment is obsolete: true
Attachment #8678054 -
Flags: review?(VYV03354)
Assignee | ||
Updated•9 years ago
|
Updated•9 years ago
|
Attachment #8678054 -
Flags: review?(VYV03354) → review+
Updated•9 years ago
|
Keywords: addon-compat,
dev-doc-needed
Comment 9•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6644bf5d558c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in
before you can comment on or make changes to this bug.
Description
•