Closed Bug 1214619 Opened 9 years ago Closed 9 years ago

Remove nsISaveAsCharset as much as possible without breaking extensions in popular use

Categories

(Core :: Internationalization, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: hsivonen, Assigned: hsivonen)

References

Details

(Keywords: addon-compat, dev-doc-needed)

Attachments

(1 file, 2 obsolete files)

Ideally, we should fix bug 1202362, but that would break https://addons.mozilla.org/en-US/firefox/addon/custom-buttons/ (and a couple of addons that only have a handful of users).

For now, let's do something that gets rid of the crufty code in nsSaveAsCharset but avoids drama with custom-buttons.
See Also: → 1202362
Attached patch Carve out the internals (obsolete) — Splinter Review
This patch breaks c-c. Hence, the dependency on bug 1202401.
Attachment #8673642 - Attachment is obsolete: true
Attachment #8676098 - Attachment is obsolete: true
Attachment #8678054 - Flags: review?(VYV03354)
No longer blocks: 1202401
Depends on: 1202401
Attachment #8678054 - Flags: review?(VYV03354) → review+
https://hg.mozilla.org/mozilla-central/rev/6644bf5d558c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.