1214621 - (Greasemonkey) Since inbounds of 14-10-2015, if I install (or update) a script, then scripts disappear in about:addons|User Scripts (the problem is caused by the fact that closing tags are appended to tags that previously self-closed in config.xml)

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Kostas]

Attachment: config.xml DIFF.jpg

To reproduce: (in win10 x64 build 10240)
- install 10-14-2015 inbounds x64 http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-inbound-win64/latest/ (1)
- install Greasemonkey 3.5beta3 (and restart FF)
- install this script: https://github.com/BrockA/SE-Edit-Reasoner,  (3)
i.e. https://github.com/BrockA/SE-Edit-Reasoner/raw/master/stack_exchange_edit_reasoner.user.js
- Observe that it works ok (press the GM toolbar icon to see the script settings as you visit http://stackexchange.com/ , or just open about:addons|User Scripts)
- Now, close and restart Firefox: you'll see that the script in about:addons|User Scripts no longer appears.



Also, on my everyday profile (where I have many scripts installed)
if I install a new script, (or update an existing one via Check for Updates) then all scripts also no longer appear.



Comparing the gm_scripts\config.xml that I had backup yesterday with the current,modified one, shows the following:
(I attach a screenshot doing a diff betweeen before and after of config.xml :
i.e. http://i.imgur.com/2CEOOCQ.jpg


In the current,modified one, for each script entry:
- there's an addition of:
xmlns="hxxp://www.w3.org/1999/xhtml"    (3)
and that 
- the <Require> and <Resourse> tags are now closed by newly added relevant closing tags (</Require> and </Resourse>)
i.e. instead of just using e.g <Require ______ />.


So, in both cases (in a clean + my current profile) 
as you close Firefox the config.xml is saved with all these extra tags appended,
therefore making it incompatible for Greasemonkey to use it.




(1) Nightly 10-13-2015 works ok
(2) I chose this script because it has <Require> and <Resourse> tags in it's metadata. 
(3) I changed hxxp into http to avoid linkification)

Comment 1

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=f73924c91a7e7614838effd1c9ead5c6027ffedc&tochange=89add5fc9f97

Suspect: 	f6759ed53f46	Aryeh Gregor — Bug 799937 - Make createElement()'s result always in the HTML namespace (except for XUL documents); r=bz

Comment 2

[Boris Zbarsky [:bzbarsky]]

Sounds like Greasemonkey is using createElement to create these elements.  Is this an issue just with the Greasemonkey beta or with whatever Greasemonkey is currently on AMO?

Hoping Anthony is still actively involved in Greasemonkey stuff...

Comment 3

[Kostas]

(In reply to Boris Zbarsky [:bz] from comment #2)
> Is this an issue just with the Greasemonkey beta or with whatever
> Greasemonkey is currently on AMO?
It occurs with GM 3.4.1 stable too.

Comment 4

[Boris Zbarsky [:bzbarsky]]

OK.  I've just backed out bug 799937, so this should be fixed.  Thank you for the quick bug report!