1214625 - pulse_actions: Fill in a revision on aurora tries to trigger non-pgo talos builders

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Armen [:armenzg]]

It tries to trigger the following:
> Windows 7 32-bit mozilla-aurora talos chromez
but it should be:
> Windows 7 32-bit mozilla-aurora talos pgo chromez


Oct 14 04:42:46 pulse-actions app/worker2.1: INFO:	 === 01e92f8049cc === 
Oct 14 04:42:46 pulse-actions app/worker2.1: INFO:	 We want to have 1 job(s) of Windows 7 32-bit mozilla-aurora talos chromez on revision 01e92f8049cc 
Oct 14 04:42:47 pulse-actions app/worker2.1: INFO:	 We have found 0 potential job(s) matching 'Windows 7 32-bit mozilla-aurora talos chromez' on 01e92f8049cc. We need to trigger more. 
Oct 14 04:42:47 pulse-actions app/worker2.1: INFO:	 ===> We want to trigger 'Windows 7 32-bit mozilla-aurora talos chromez' on revision '01e92f8049cc' a total of 1 time(s). 
Oct 14 04:42:47 pulse-actions app/worker2.1: INFO:	  
Oct 14 04:42:47 pulse-actions app/worker2.1: WARNING:	 Buildername None is *NOT* valid. 
Oct 14 04:42:47 pulse-actions app/worker2.1: INFO:	 Check the file we just created builders.txt for a list of valid builders. 
Oct 14 04:42:47 pulse-actions app/worker2.1: Traceback (most recent call last): 
Oct 14 04:42:47 pulse-actions app/worker2.1:   File "pulse_actions/worker.py", line 73, in run_pulse 
Oct 14 04:42:47 pulse-actions app/worker2.1:     pulse.listen() 
Oct 14 04:42:47 pulse-actions app/worker2.1:   File "/app/.heroku/python/lib/python2.7/site-packages/mozillapulse/consumers.py", line 151, in listen 
Oct 14 04:42:47 pulse-actions app/worker2.1:     self._drain_events_loop() 
Oct 14 04:42:47 pulse-actions app/worker2.1:   File "/app/.heroku/python/lib/python2.7/site-packages/mozillapulse/consumers.py", line 198, in _drain_events_loop 
Oct 14 04:42:47 pulse-actions app/worker2.1:     self.connection.drain_events(timeout=self.timeout) 
Oct 14 04:42:47 pulse-actions app/worker2.1:   File "/app/.heroku/python/lib/python2.7/site-packages/kombu/connection.py", line 275, in drain_events 
Oct 14 04:42:47 pulse-actions app/worker2.1:     return self.transport.drain_events(self.connection, **kwargs) 
Oct 14 04:42:47 pulse-actions app/worker2.1:   File "/app/.heroku/python/lib/python2.7/site-packages/kombu/transport/pyamqp.py", line 95, in drain_events 
Oct 14 04:42:47 pulse-actions app/worker2.1:     return connection.drain_events(**kwargs) 
Oct 14 04:42:47 pulse-actions app/worker2.1:   File "/app/.heroku/python/lib/python2.7/site-packages/amqp/connection.py", line 325, in drain_events 
Oct 14 04:42:47 pulse-actions app/worker2.1:     return amqp_method(channel, args, content) 
Oct 14 04:42:47 pulse-actions app/worker2.1:   File "/app/.heroku/python/lib/python2.7/site-packages/amqp/channel.py", line 1909, in _basic_deliver 
Oct 14 04:42:47 pulse-actions app/worker2.1:     fun(msg) 
Oct 14 04:42:47 pulse-actions app/worker2.1:   File "/app/.heroku/python/lib/python2.7/site-packages/kombu/messaging.py", line 596, in _receive_callback 
Oct 14 04:42:47 pulse-actions app/worker2.1:     return on_m(message) if on_m else self.receive(decoded, message) 
Oct 14 04:42:47 pulse-actions app/worker2.1:   File "/app/.heroku/python/lib/python2.7/site-packages/kombu/messaging.py", line 563, in receive 
Oct 14 04:42:47 pulse-actions app/worker2.1:     [callback(body, message) for callback in callbacks] 
Oct 14 04:42:47 pulse-actions app/worker2.1:   File "pulse_actions/worker.py", line 64, in handler_with_dry_run 
Oct 14 04:42:47 pulse-actions app/worker2.1:     return event_handler(data, message, dry_run) 
Oct 14 04:42:47 pulse-actions app/worker2.1:   File "/app/pulse_actions/handlers/route_functions.py", line 12, in route 
Oct 14 04:42:47 pulse-actions app/worker2.1:     treeherder_resultset.on_resultset_action_event(data, message, dry_run) 
Oct 14 04:42:47 pulse-actions app/worker2.1:   File "/app/pulse_actions/handlers/treeherder_resultset.py", line 32, in on_resultset_action_event 
Oct 14 04:42:47 pulse-actions app/worker2.1:     trigger_missing_jobs_for_revision(repo_name, revision, dry_run=dry_run) 
Oct 14 04:42:47 pulse-actions app/worker2.1:   File "/app/.heroku/python/lib/python2.7/site-packages/mozci/mozci.py", line 505, in trigger_missing_jobs_for_revision 
Oct 14 04:42:47 pulse-actions app/worker2.1:     'type': 'trigger_missing_jobs_for_revision'} 
Oct 14 04:42:47 pulse-actions app/worker2.1:   File "/app/.heroku/python/lib/python2.7/site-packages/mozci/mozci.py", line 460, in trigger_range 
Oct 14 04:42:47 pulse-actions app/worker2.1:     trigger_build_if_missing=trigger_build_if_missing) 
Oct 14 04:42:47 pulse-actions app/worker2.1:   File "/app/.heroku/python/lib/python2.7/site-packages/mozci/mozci.py", line 363, in trigger_job 
Oct 14 04:42:47 pulse-actions app/worker2.1:     trigger_build_if_missing 
Oct 14 04:42:47 pulse-actions app/worker2.1:   File "/app/.heroku/python/lib/python2.7/site-packages/mozci/mozci.py", line 114, in _determine_trigger_objective 
Oct 14 04:42:47 pulse-actions app/worker2.1:     "Our platforms mapping system has failed." 
Oct 14 04:42:47 pulse-actions app/worker2.1: AssertionError: Our platforms mapping system has failed.

Comment 1

[Armen [:armenzg]]

Branch for this bug:
https://github.com/armenzg/mozilla_ci_tools/tree/fix_trigger_missing_jobs

Comment 2

[Armen [:armenzg]]

Adding sheriffs.

Filling a revision on aurora and beta is bond to fail.
I'm working on a fix and it should be landed by tomorrow.

Comment 3

[Armen [:armenzg]]

I landed a major refactoring to mozci + I deal with this issue:
https://github.com/armenzg/mozilla_ci_tools/commit/21591a35bf84bc2f4b741ce9949b2e6f6c753ba9

The block that deals with talos builders for m-a and m-b is:
https://github.com/armenzg/mozilla_ci_tools/blob/master/mozci/platforms.py#L439

I will test a bit more before making a new release of mozci and bump it in pulse_actions.

Comment 4

[Armen [:armenzg]]

FYI this is due to bug 1149514 where we have 2 sets of talos builders (pgo and non-pgo) even though there is only one build job.
This means that the opt talos builders don't have a builder to trigger them.

Landed version bump and deployed in here:
https://github.com/adusca/pulse_actions/commit/4196458e77f92164bf38d20835900556e0bafde4

No alerts have happened since then.

Comment 5

[Armen [:armenzg]]

I need to change setup.py to use the requirements.txt file and bump that (Heroku ignores setup.py if requirements.txt exists)

Comment 6

[Armen [:armenzg]]

Landed properly (and preventing me from making the same mistake):
https://github.com/armenzg/pulse_actions/commit/4728c88d4f4255da561671e11d8a08b6170a8194