1214676 - Cancel button in Send To and Share To extensions is not localized

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

The problem is that we changed from UIBarButtonSystemItem.Cancel to an NSLocalizedString.

Unfortunately those strings did not get a string table, so they are not available in the extensions.

As a result, the Send To and Share To dialogs have a fixed English Cancel string.

My suggested fix is that we switch back to UIBarButtonSystemItem.Cancel now and change to locale specific Cancel text for the next release.

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: PR: https://github.com/mozilla/firefox-ios/pull/1156

This patch reverts back to the use of UIBarButtonSystemItem.Cancel for two buttons that are not localized correctly because of missing strings.

Comment 2

[Stefan Plewako [:stef]]

https://github.com/mozilla/firefox-ios/commit/41d169085981290258a732fb122eba77021e062c exposed (see https://github.com/splewako/firefox-ios-l10n-en/commit/4d77cae74ea45822f40c61c66be5f7b449a8e572) bunch of l10n notes and at least two need rewording ("Cancel alert view", "Cancel title from search engine picker").