[Raptor] Pre-commit hooks

RESOLVED FIXED

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: rwood, Assigned: rwood)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

3 years ago
Created attachment 8680064 [details] [review]
https://github.com/mozilla-raptor/raptor-cli/pull/36

Add local pre-commit eslint testing via ghooks.
Attachment #8680064 - Flags: review?(eperelman)

Comment 2

3 years ago
Comment on attachment 8680064 [details] [review]
https://github.com/mozilla-raptor/raptor-cli/pull/36

Just one comment, looks good.
Attachment #8680064 - Flags: review?(eperelman) → review+
(Assignee)

Comment 3

3 years ago
Thanks Eli, landed:

https://github.com/mozilla-raptor/raptor-cli/commit/86718cc9a58eb648b25a682ecd44f3917f6f9d23

No version bump/publish required.

The pre-commit hooks will be updated in the future when Raptor unit tests are developed; but that will be done in a different bug along with the unit tests.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.