1214743 - Template problem with first_date in new TCBS

Status: RESOLVED FIXED

(Socorro :: Webapp, task, P2)

Description

[Peter Bengtsson [:peterbe]]

Steps to reproduce;
1) visit https://crash-stats.allizom.org/topcrashers/?product=Firefox&version=40.0.2&date_range_type=report&process_type=browser&platform=&_facets_size=50&days=7

Error: https://errormill.mozilla.org/webtools/socorro-stage/group/400949/

Comment 1

[Peter Bengtsson [:peterbe]]

This code assumes it's always there 
https://github.com/mozilla/socorro/blob/b4f2a1fa6f65c5967cdfae6eb1bb22eb0779a068/webapp-django/crashstats/topcrashers/templates/topcrashers/topcrashers.html#L170-L174

But this code allows it to not exist
https://github.com/mozilla/socorro/blob/b4f2a1fa6f65c5967cdfae6eb1bb22eb0779a068/webapp-django/crashstats/topcrashers/views.py#L334-L336

Incidentally, when I tried a third time to run it so I can print debug that the `sig` value was, it worked. Nevertheless, there's a logic flaw in the view code and the template.

Comment 2

[[DEACTIVATED] Adrian Gaudebert]

PR: https://github.com/mozilla/socorro/pull/3039

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/9b410d1202bad0c7da387c236edc455461018808
Fixes bug 1214743 - Fixed error when no first date for a signature. r=peterbe