1214758 - st-an builds incorrectly use .linux64 and .macosx64 routes

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Michael Shal [:mshal]]

The static analysis build configurations inherit from the base linux/mac configurations, but the base linux/mac configs specify some buildbot.* routes. For example, linux64_clobber.yml has:

  routes:
    - 'index.buildbot.branches.{{project}}.linux64'
    - 'index.buildbot.revisions.{{head_rev}}.{{project}}.linux64'

Since the st-an builds inherit this file in addition to providing their own routes, they have multiple buildbot routes:

    "index.buildbot.branches.mozilla-central.linux64",
    "index.buildbot.revisions.None.mozilla-central.linux64",
    "index.buildbot.branches.mozilla-central.linux64-st-an",
    "index.buildbot.revisions.None.mozilla-central.linux64-st-an",

The st-an builds shouldn't be publishing to .linux64 / .macosx64

Although I'd like to remove these buildbot routes entirely at some point, we aren't ready to do so yet.

Comment 1

[Michael Shal [:mshal]]

Attachment: 0001-Bug-1214758-remove-.linux64-.macosx64-routes-from-st.patch

This was a bit annoying to refactor since some of the intermediate files in the hierarchy are also themselves tasks (eg: opt_linux64_clobber.yml is referenced from try/job_flags.yml and also inherited by other tasks). If there is a better way to do this, please let me know!

Comment 2

[Michael Shal [:mshal]]

Attachment: debug-tc.patch

I was using this patch to help debug taskcluster-graph - it stubs out all of the variable things (like taskIds and dates and such), so that you can diff the output from './mach taskcluster-graph ...'.

Is there a better way to do that? Some sort of dry-run capability or something? I wanted to make sure I wasn't deleting routes or changing the build configuration inadvertently.

Comment 3

[Greg Arndt [:garndt]]

Comment on attachment 8673799 [details] [diff] [review]
0001-Bug-1214758-remove-.linux64-.macosx64-routes-from-st.patch

Review of attachment 8673799 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me.

Comment 4

[Greg Arndt [:garndt]]

(In reply to Michael Shal [:mshal] from comment #2)
> Created attachment 8673801 [details] [diff] [review]
> debug-tc.patch
> 
> I was using this patch to help debug taskcluster-graph - it stubs out all of
> the variable things (like taskIds and dates and such), so that you can diff
> the output from './mach taskcluster-graph ...'.
> 
> Is there a better way to do that? Some sort of dry-run capability or
> something? I wanted to make sure I wasn't deleting routes or changing the
> build configuration inadvertently.

I'm not aware of a better way, and this is neat.  I usually just do a diff and ignore the date related changes although this one definitely reduces a lot of the noise.

I think we need to determine the longevity of the mach command and if it's worth investing in some of these niceties that definitely come in useful.  Thanks for attaching the patch so I could take a look!

Comment 5

[Pulsebot]

https://hg.mozilla.org/mozilla-central/rev/f1a04b2e2baf

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f1a04b2e2baf