Closed Bug 1214764 Opened 9 years ago Closed 9 years ago

1,600 instances of "NS_ENSURE_TRUE(globalObject && globalObject->GetGlobalJSObject()) failed" emitted from dom/base/nsDocument.cpp during linux64 debug testing

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: erahm, Assigned: erahm)

Details

Attachments

(1 file)

This seems to be primarily emitted during shutdown. Given that it's properly handled (|nsDocument::IsScriptEnabled| returns false, callers check for that) I'm inclined to just remove the warning and return false directly.
 
> 1604 [NNNNN] WARNING: NS_ENSURE_TRUE(globalObject && globalObject->GetGlobalJSObject()) failed: file dom/base/nsDocument.cpp, line 8354

This warning [1], introduced in bug 840488, shows up in the following test suites:

> mozilla-central_ubuntu64_vm-debug_test-mochitest-other-bm67-tests1-linux64-build0.txt:224
> mozilla-central_ubuntu64_vm-debug_test-mochitest-2-bm54-tests1-linux64-build1.txt:113
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-2-bm68-tests1-linux64-build1.txt:98
> mozilla-central_ubuntu64_vm-debug_test-mochitest-4-bm121-tests1-linux64-build3.txt:93
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-4-bm52-tests1-linux64-build17.txt:83
> mozilla-central_ubuntu64_vm-debug_test-mochitest-5-bm68-tests1-linux64-build28.txt:70
> mozilla-central_ubuntu64_vm-debug_test-mochitest-3-bm125-tests1-linux64-build2.txt:68
> mozilla-central_ubuntu64_vm-debug_test-mochitest-1-bm52-tests1-linux64-build0.txt:65
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-5-bm53-tests1-linux64-build11.txt:58
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-1-bm121-tests1-linux64-build1.txt:58
> mozilla-central_ubuntu64_vm-debug_test-crashtest-bm68-tests1-linux64-build9.txt:55
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-3-bm68-tests1-linux64-build1.txt:54
> mozilla-central_ubuntu64_vm-debug_test-crashtest-e10s-bm125-tests1-linux64-build4.txt:53
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-5-bm121-tests1-linux64-build3.txt:26
> mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-1-bm121-tests1-linux64-build2.txt:26
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-4-bm118-tests1-linux64-build1.txt:24
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-1-bm68-tests1-linux64-build10.txt:24
> mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-6-bm116-tests1-linux64-build3.txt:24
> mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-5-bm68-tests1-linux64-build9.txt:24
> mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-3-bm118-tests1-linux64-build4.txt:24
> mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-2-bm113-tests1-linux64-build3.txt:24
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-3-bm124-tests1-linux64-build1.txt:22
> mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-4-bm116-tests1-linux64-build1.txt:22
> mozilla-central_ubuntu64_vm-debug_test-reftest-e10s-1-bm124-tests1-linux64-build3.txt:21
> mozilla-central_ubuntu64_vm-debug_test-mochitest-devtools-chrome-4-bm123-tests1-linux64-build38.txt:21
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-2-bm51-tests1-linux64-build8.txt:18
> mozilla-central_ubuntu64_vm-debug_test-mochitest-devtools-chrome-2-bm52-tests1-linux64-build2.txt:18
> mozilla-central_ubuntu64_vm-debug_test-reftest-2-bm123-tests1-linux64-build37.txt:17
> mozilla-central_ubuntu64_vm-debug_test-mochitest-devtools-chrome-3-bm68-tests1-linux64-build2.txt:17
> mozilla-central_ubuntu64_vm-debug_test-web-platform-tests-e10s-6-bm51-tests1-linux64-build2.txt:14
> mozilla-central_ubuntu64_vm-debug_test-web-platform-tests-6-bm123-tests1-linux64-build1.txt:14
> mozilla-central_ubuntu64_vm-debug_test-reftest-e10s-2-bm124-tests1-linux64-build3.txt:14
> mozilla-central_ubuntu64_vm-debug_test-mochitest-devtools-chrome-1-bm121-tests1-linux64-build5.txt:14
> mozilla-central_ubuntu64_vm-debug_test-reftest-4-bm115-tests1-linux64-build50.txt:10
> mozilla-central_ubuntu64_vm-debug_test-mochitest-jetpack-bm121-tests1-linux64-build0.txt:10
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-7-bm121-tests1-linux64-build15.txt:8
> mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-7-bm123-tests1-linux64-build0.txt:8
> mozilla-central_ubuntu64_vm-debug_test-web-platform-tests-e10s-4-bm113-tests1-linux64-build2.txt:6
> mozilla-central_ubuntu64_vm-debug_test-web-platform-tests-e10s-3-bm54-tests1-linux64-build1.txt:6
> mozilla-central_ubuntu64_vm-debug_test-web-platform-tests-4-bm54-tests1-linux64-build28.txt:6
> mozilla-central_ubuntu64_vm-debug_test-web-platform-tests-3-bm121-tests1-linux64-build17.txt:6
> mozilla-central_ubuntu64_vm-debug_test-web-platform-tests-reftests-e10s-bm115-tests1-linux64-build7.txt:4
> mozilla-central_ubuntu64_vm-debug_test-web-platform-tests-reftests-bm115-tests1-linux64-build1.txt:4
> mozilla-central_ubuntu64_vm-debug_test-reftest-3-bm68-tests1-linux64-build2.txt:4
> mozilla-central_ubuntu64_vm-debug_test-reftest-1-bm125-tests1-linux64-build1.txt:4
> mozilla-central_ubuntu64_vm-debug_test-mochitest-gl-bm113-tests1-linux64-build3.txt:4
> mozilla-central_ubuntu64_vm-debug_test-web-platform-tests-e10s-8-bm123-tests1-linux64-build4.txt:2
> mozilla-central_ubuntu64_vm-debug_test-web-platform-tests-e10s-7-bm68-tests1-linux64-build4.txt:2
> mozilla-central_ubuntu64_vm-debug_test-web-platform-tests-e10s-5-bm118-tests1-linux64-build3.txt:2
> mozilla-central_ubuntu64_vm-debug_test-web-platform-tests-e10s-2-bm123-tests1-linux64-build3.txt:2
> mozilla-central_ubuntu64_vm-debug_test-web-platform-tests-e10s-1-bm124-tests1-linux64-build4.txt:2
> mozilla-central_ubuntu64_vm-debug_test-web-platform-tests-8-bm52-tests1-linux64-build3.txt:2
> mozilla-central_ubuntu64_vm-debug_test-web-platform-tests-7-bm113-tests1-linux64-build0.txt:2
> mozilla-central_ubuntu64_vm-debug_test-web-platform-tests-5-bm51-tests1-linux64-build6.txt:2
> mozilla-central_ubuntu64_vm-debug_test-web-platform-tests-2-bm115-tests1-linux64-build0.txt:2
> mozilla-central_ubuntu64_vm-debug_test-web-platform-tests-1-bm116-tests1-linux64-build3.txt:2
> mozilla-central_ubuntu64_vm-debug_test-mochitest-push-bm123-tests1-linux64-build28.txt:2
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-6-bm125-tests1-linux64-build2.txt:2

It shows up in      188 tests. A few of the most prevalent:

> 1094 - Shutdown
> 14 - dom/base/test/chrome/test_domparsing.xul
> 10 - dom/xbl/test/test_bug389322.xhtml
> 8 - parser/htmlparser/tests/mochitest/test_bug102699.html
> 8 - browser/base/content/test/general/browser_bug592338.js
> 8 - /domparsing/DOMParser-parseFromString-xml.html
> 6 - dom/events/test/test_bug391568.xhtml
> 5 - chrome://mochitests/content/a11y/accessible/tests/mochitest/relations/test_bindings.xhtml
> 5 - chrome://mochitests/content/a11y/accessible/tests/mochitest/events/test_mutation.xhtml
> 4 - widget/tests/test_plugin_scroll_invalidation.html

[1] https://hg.mozilla.org/mozilla-central/annotate/2387ada864282880d3a498d643abe3d8b887ee59/dom/base/nsDocument.cpp#l8315
Sounds good to me.
Assignee: nobody → erahm
Status: NEW → ASSIGNED
Comment on attachment 8674976 [details] [diff] [review]
Convert NS_ENSURE to a plain return in nsDocument::IsScriptEnabled

Review of attachment 8674976 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8674976 - Flags: review?(bobbyholley) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/a1ef71b0eff58ad23616ebe1d4f963461d3944c3
Bug 1214764 - Convert NS_ENSURE to a plain return in nsDocument::IsScriptEnabled. r=bholley
https://hg.mozilla.org/mozilla-central/rev/a1ef71b0eff5
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: