1214771 - [NGA] Improve render performance of all list views

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Wilson Page [:wilsonpage]]

Tracking the landing of new version of <gaia-fast-list> that will come with improved render performance via caching and gfx optimizations.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] wilsonpage:1214771 > mozilla-b2g:master

Comment 2

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8677996 [details] [review]
[gaia] wilsonpage:1214771 > mozilla-b2g:master

Almost there, just have some nits/code styling issues to resolve. Namely, I'd rather consistently refer to the <music-search-box> and <music-search-results> elements via `this.searchBox` and `this.searchResults` everywhere. Especially now that we have fat-arrow functions, we shouldn't need to declare local vars like this to maintain scope anymore and it can add confusion when others have to follow the code later (not saying that the code is hard to follow right now, but trying to keep things consistent for the future).

Comment 3

[Wilson Page [:wilsonpage]]

(In reply to Justin D'Arcangelo [:justindarc] from comment #2)
> Comment on attachment 8677996 [details] [review]
> [gaia] wilsonpage:1214771 > mozilla-b2g:master
> 
> Almost there, just have some nits/code styling issues to resolve. Namely,
> I'd rather consistently refer to the <music-search-box> and
> <music-search-results> elements via `this.searchBox` and
> `this.searchResults` everywhere. Especially now that we have fat-arrow
> functions, we shouldn't need to declare local vars like this to maintain
> scope anymore and it can add confusion when others have to follow the code
> later (not saying that the code is hard to follow right now, but trying to
> keep things consistent for the future).

Cool I'll fix that up :)

It might be nice to use the `this.els` prefix so that readers know it's an element. But that's nothing to do with this bug :)

Comment 4

[Wilson Page [:wilsonpage]]

Comment on attachment 8677996 [details] [review]
[gaia] wilsonpage:1214771 > mozilla-b2g:master

Comments addressed :)

Comment 5

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8677996 [details] [review]
[gaia] wilsonpage:1214771 > mozilla-b2g:master

Looks so much cleaner.. Thanks! :-)

Comment 6

[Wilson Page [:wilsonpage]]

Comment on attachment 8677996 [details] [review]
[gaia] wilsonpage:1214771 > mozilla-b2g:master

https://github.com/mozilla-b2g/gaia/commit/5cac0f04e7ad02e85527451c065bd1aeafcd74ce