1214799 - Localize memory tool

Status: RESOLVED FIXED

(DevTools :: Memory, defect)

Description

[Jordan Santell [:jsantell] [@jsantell]]

Before we launch we should change all hardcoded strings to be localized.

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Strings we need:

* Take snapshot button on load

States, for list items as well as in the big panel (may be different? strings in list item need to be relatively short:
* Saving a snapshot
* Reading a snapshot -- I think "Reading snapshot into memory" is a bit confusing, since it is the memory tool.
* Taking census -- What's a good, public-facing name for Censuses and Breakdowns?

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1214799-memory-l10n.patch

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8680483 [details] [diff] [review]
1214799-memory-l10n.patch

Review of attachment 8680483 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/memory/constants.js
@@ +6,5 @@
>  
> +const { Cu } = require("chrome");
> +Cu.import("resource://devtools/client/shared/widgets/ViewHelpers.jsm");
> +const STRINGS_URI = "chrome://browser/locale/devtools/memory.properties"
> +const L10N = exports.L10N = new ViewHelpers.L10N(STRINGS_URI);

Think this belongs in utils, not constants.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/d8823aea3812

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d8823aea3812

Comment 7

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

https://treeherder.mozilla.org/#/jobs?repo=mozilla-aurora&revision=cb029edb917f

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/d8823aea3812

Comment 9

[Carsten Book [:Tomcat]]

removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/155c73a3000e