Closed Bug 1214857 Opened 6 years ago Closed 6 years ago

getElementsByTagName should snapshot the HTMLness of the document at call time

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file)

No description provided.
Depends on: 1214783
Comment on attachment 8674271 [details] [diff] [review]
Store the document-is-HTML state directly in nsContentList instead of refetching from the node being matched

>+  // We have to take an aIsHTMLDocument arg for two reasons:
>+  // 1)  We don't want to include nsIDocument.h in this header.
>+  // 2) We need to do that to make nsContentList::RemoveFromHashtable
Extra space after 1)

>+++ b/testing/web-platform/mozilla/meta/MANIFEST.json
>@@ -422,16 +422,22 @@
>           }
>         ],
>         "service-workers/service-worker/resources/invalid-header-iframe.https.html": [
>           {
>             "path": "service-workers/service-worker/resources/invalid-header-iframe.https.html",
>             "url": "/_mozilla/service-workers/service-worker/resources/invalid-header-iframe.https.html"
>           }
>         ],
>+        "service-workers/service-worker/resources/worker-interception-iframe.https.html": [
>+          {
>+            "path": "service-workers/service-worker/resources/worker-interception-iframe.https.html",
>+            "url": "/_mozilla/service-workers/service-worker/resources/worker-interception-iframe.https.html"
>+          }
>+        ],

This is some unrelated change
Attachment #8674271 - Flags: review?(bugs) → review+
> This is some unrelated change

This change is due to running the manifest update script after adding the new test.  Basically, someone added that serviceworker test but didn't update the manifest so the test is not running right now....
https://hg.mozilla.org/mozilla-central/rev/413327d4c524
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.