All users were logged out of Bugzilla on October 13th, 2018

getElementsByTagName should snapshot the HTMLness of the document at call time

RESOLVED FIXED in Firefox 44

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Tracking

Trunk
mozilla44
Points:
---

Firefox Tracking Flags

(firefox44 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

3 years ago
Depends on: 1214783
(Assignee)

Comment 1

3 years ago
Created attachment 8674271 [details] [diff] [review]
Store the document-is-HTML state directly in nsContentList instead of refetching from the node being matched
Attachment #8674271 - Flags: review?(bugs)

Comment 2

3 years ago
Comment on attachment 8674271 [details] [diff] [review]
Store the document-is-HTML state directly in nsContentList instead of refetching from the node being matched

>+  // We have to take an aIsHTMLDocument arg for two reasons:
>+  // 1)  We don't want to include nsIDocument.h in this header.
>+  // 2) We need to do that to make nsContentList::RemoveFromHashtable
Extra space after 1)

>+++ b/testing/web-platform/mozilla/meta/MANIFEST.json
>@@ -422,16 +422,22 @@
>           }
>         ],
>         "service-workers/service-worker/resources/invalid-header-iframe.https.html": [
>           {
>             "path": "service-workers/service-worker/resources/invalid-header-iframe.https.html",
>             "url": "/_mozilla/service-workers/service-worker/resources/invalid-header-iframe.https.html"
>           }
>         ],
>+        "service-workers/service-worker/resources/worker-interception-iframe.https.html": [
>+          {
>+            "path": "service-workers/service-worker/resources/worker-interception-iframe.https.html",
>+            "url": "/_mozilla/service-workers/service-worker/resources/worker-interception-iframe.https.html"
>+          }
>+        ],

This is some unrelated change
Attachment #8674271 - Flags: review?(bugs) → review+
(Assignee)

Comment 3

3 years ago
> This is some unrelated change

This change is due to running the manifest update script after adding the new test.  Basically, someone added that serviceworker test but didn't update the manifest so the test is not running right now....
https://hg.mozilla.org/mozilla-central/rev/413327d4c524
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox44: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.