1214860 - We fetch a lot of unnecessary data in perfherder compare

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect)

Description

[William Lachance (:wlach)]

We fetch the full range of data incorporating the revisions we care about in perfherder compare, even though we only care about the data corresponding to the two result sets we're worried about. With the database refactoring, we can quickly look up just this subset of data. Let's take advantage of that, and hopefully clean things up a bit at the same time.

This will ease implementation of bug 1187000, I hope.

Comment 1

[William Lachance (:wlach)]

Attachment: PR

This change improves the load times from about 6.5s -> 4s on a week old comparison (https://treeherder.mozilla.org/perf.html#/compare?originalProject=mozilla-inbound&originalRevision=906f76d5adcf&newProject=mozilla-inbound&newRevision=3012b7a2c97c). The savings would be even greater on an older comparison.

Further improvements are possible, but probably not worth the effort at this juncture.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8) (PTO back normal Nov 17)]

Comment on attachment 8675128 [details] [review]
PR

this was pretty simple

Comment 3

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/9e6e70cd773ab99335c6cd3c8f7257de4f674854
Bug 1214860 - Reduce amount of data loaded in perfherder compare view

We only need the data associated with the result sets we are comparing,
instead of a large time interval covering it.