Event dialog: Remove All Attachments fails with TypeError: child is undefined

RESOLVED FIXED in 4.7

Status

defect
--
minor
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: ssitter, Assigned: bv1578)

Tracking

Lightning 4.6

Details

Attachments

(1 attachment, 1 obsolete attachment)

Reporter

Description

4 years ago
Using Thunderbird 44.0a1 (2015-10-14) with Lightning 4.6a1 (2015-10-14)

Steps to reproduce:
1. Create new event or edit event
2. Add two or more web page attachments
3. Open context menu in Attachments field at the bottom of the dialog
4. Choose Remove All from context menu
5. Confirm the message box to remove all attachments

Actual result:
Only one attachment is removed. Error Console shows:

Error: TypeError: child is undefined
Source File: chrome://calendar/content/calendar-event-dialog.js
Line: 2245
Assignee

Comment 1

4 years ago
Posted patch patch - v1 (obsolete) — Splinter Review
It seems that remove() doesn't return the removed node.

Is the statement 
  child.attachment = null;
strictly necessary?
Assignee: nobody → bv1578
Status: NEW → ASSIGNED
Attachment #8674167 - Flags: review?(philipp)
Comment on attachment 8674167 [details] [diff] [review]
patch - v1

Review of attachment 8674167 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, and probably doesn't hurt to push this to aurora too so it will be available with Thunderbird 45.
Attachment #8674167 - Flags: review?(philipp)
Attachment #8674167 - Flags: review+
Attachment #8674167 - Flags: approval-calendar-aurora+
Assignee

Comment 3

4 years ago
Attachment #8674167 - Attachment is obsolete: true
Attachment #8699907 - Flags: review+
Assignee

Updated

4 years ago
Keywords: checkin-needed

Comment 4

4 years ago
https://hg.mozilla.org/comm-central/rev/9dbe520925358752a89dbc26c43ed38c63ef6be2
Bug 1214870 - Event dialog: Remove All Attachments fails with TypeError: child is undefined. r=philipp

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 4.8
Comment on attachment 8699907 [details] [diff] [review]
patch for checkin

Re-added aurora approval.
Attachment #8699907 - Flags: approval-calendar-aurora+
Backported to releases/comm-aurora changeset b11593b6699c
Keywords: checkin-needed
Target Milestone: 4.8 → 4.7
You need to log in before you can comment on or make changes to this bug.