Closed
Bug 1214887
Opened 9 years ago
Closed 9 years ago
Intermittent browser_animation_updatedState.js | The playState is running while the transition is running - Got finished, expected running
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(firefox45 fixed)
RESOLVED
FIXED
Firefox 45
Tracking | Status | |
---|---|---|
firefox45 | --- | fixed |
People
(Reporter: KWierso, Assigned: pbro)
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
4.24 KB,
patch
|
tromey
:
review+
|
Details | Diff | Splinter Review |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 6•9 years ago
|
||
I'm going to fix this by making the animation last for 100s or something. We should never really have tests that use short-running animations, it's just too prone to intermittents like this.
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
Assignee | ||
Comment 7•9 years ago
|
||
We should never really use short animations in tests, so I changed the test so that we now use a very long animation. This should prevent any chance of the animation being finished by the time we check its playState is "running". At the end of the test, I then set its currentTime so that the test doesn't have to wait for 100s before checking that the playState goes to "finished". Pending try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6eba5d9f8f45
Attachment #8688950 -
Flags: review?(ttromey)
Updated•9 years ago
|
Attachment #8688950 -
Flags: review?(ttromey) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Reporter | ||
Comment 9•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5933bb2c0f4f
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•