1214921 - Show compatibility error if an add-on uses mozRequestAnimationFrame

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Compatibility Tools, defect)

Description

[Jorge Villalobos [:jorgev] (he/him)]

As explained in bug 909154, mozRequestAnimationFrame was unprefixed to requestAnimationFrame. We need to show a compatibility error for every instance found of mozRequestAnimationFrame.

Note that many SDK add-ons (like https://addons.mozilla.org/addon/google-documents-viewer/) have a comment line that refer to mozRequestAnimationFrame, so please make sure those aren't flagged.

This is a compatibility error, so the add-on shouldn't be upgraded in this case. It should also appear as a warning in regular validations.

Message:

mozRequestAnimationFrame is no longer supported in prefixed form, please use requestAnimationFrame instead. See <LINK> for more information.

Link: https://developer.mozilla.org/en-US/docs/Web/API/window/requestAnimationFrame

Affected add-on:

https://addons.mozilla.org/addon/smoothwheel/

Release timing:

Firefox 42 will be released on November 3rd.

Comment 1

[Mathieu Agopian [:magopian]]

PR: https://github.com/mozilla/amo-validator/pull/334/files

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/amo-validator

https://github.com/mozilla/amo-validator/commit/d44118d8e34ea5e7fb0efffa2e1dc0ff11c36cef
Show compatibility error if an add-on uses mozRequestAnimationFrame (pair with cgrebs) (bug 1214921)

Comment 3

[krupa raj[:krupa]]

compat failure  is seen as expected at https://addons.allizom.org/en-US/developers/upload/c9e250c1a5b0411e8b08c64bfe333ba0

However checking for https://addons.mozilla.org/addon/google-documents-viewer/ results in an unexpcted error https://addons.allizom.org/en-US/developers/upload/7b92266cbb3841ef9d06eb8d84baf57a

Comment 4

[Mathieu Agopian [:magopian]]

The "unexpected error" should be fixed in https://github.com/mozilla/amo-validator/pull/337 (on -dev at least, not sure it's on stage yet).

Comment 5

[krupa raj[:krupa]]

verified fixed on dev.