1214926 - Show compatibility error if an add-on uses newTab.xul

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Compatibility Tools, defect)

Description

[Jorge Villalobos [:jorgev] (he/him)]

As explained in bug 1167601, newTab.xul is now newTab.xhtml. We need to show a compatibility error for every instance found of "chrome://browser/content/newtab/newTab.xul" (without quotes).

This is a compatibility error, so the add-on shouldn't be upgraded in this case. It should also appear as a warning in regular validations.

Message:

newTab.xul is now newTab.xhtml. See <LINK> for more information.

Link: https://bugzilla.mozilla.org/show_bug.cgi?id=1167601

Affected add-on:

https://addons.mozilla.org/addon/lista-centrum-cz/

Release timing:

Firefox 42 will be released on November 3rd.

Comment 1

[Mathieu Agopian [:magopian]]

PR: https://github.com/mozilla/amo-validator/pull/334

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/amo-validator

https://github.com/mozilla/amo-validator/commit/2f02b521dbba72e7eb918a5c7cf5aed1154e1f38
Show compatibility error if an add-on uses newTab.xul (pair with cgrebs) (bug 1214926)

Comment 3

[krupa raj[:krupa]]

The affected add-on listed passes validation. Reopening for investigation.

screenshot: https://www.dropbox.com/s/hf0n6bgqvs9o6ll/Screenshot%202015-10-29%2009.27.07.png?dl=0

Comment 4

[Mathieu Agopian [:magopian]]

Should be fixed in https://github.com/mozilla/amo-validator/pull/337. Can you please give it another try (on -dev for now, don't think it's on stage yet)

Comment 5

[krupa raj[:krupa]]

verified fixed at https://addons-dev.allizom.org/en-US/developers/upload/ad6f6559c75c4683b28f87f864ac5ec1